cleanup redundant logs in cns savestate-file, createorUpdateNetworkCo… #2442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
approved these changes
Dec 18, 2023
rbtr
reviewed
Dec 18, 2023
| } else { | ||
| logger.Errorf("[Azure CNS] Failed to save state., err:%v\n", err) | ||
| if err != nil { | ||
| logger.Errorf("[Azure CNS] Failed to save state, err: %v", err) |
There was a problem hiding this comment.
maybe we don't need to log an error in this method if we're returning it and the caller can log it instead?
There was a problem hiding this comment.
for this method saveState() there are quite a few usages (~13) & all of them do not log the error currently, may require some work there probably we can address in next PR
ramiro-gamarra
approved these changes
Dec 18, 2023
matmerr
pushed a commit
that referenced
this pull request
Jan 17, 2024
#2442) cleanup redundant logs in cns savestate-file, createorUpdateNetworkContainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntainer
Reason for Change:
Improve database threshold by removing non-useful log lines with no data. Currently these 3 log lines contribute to approximately 33% of the cns logs in DB & yet give no data related to the request. This gives us more space to add useful log lines in future & save data to customers running CNS instances.
Issue Fixed:
Requirements:
Notes: