Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migration stateless cni #2470

Merged
merged 17 commits into from
Feb 9, 2024
Merged

feat: Migration stateless cni #2470

merged 17 commits into from
Feb 9, 2024

Conversation

behzad-mir
Copy link
Contributor

This PR contains code changes related to Stateless CNI Migration.
1- There has been code change to use cnireconciler when the managedEndpoint and Migration flag on CNS is set.
2- There has been code changes on CNI GetEndpoint function to fetch the HNS Endpoint corresponded to an IP address to cover the cases for the missing HNSEndpointID in statefile.

Notes:

@behzad-mir behzad-mir requested review from a team as code owners January 4, 2024 18:30
@behzad-mir behzad-mir added the cni Related to CNI. label Jan 4, 2024
@behzad-mir behzad-mir force-pushed the Migration-StatlessCNI branch 3 times, most recently from 0bd3047 to 5d21612 Compare January 5, 2024 06:54
tamilmani1989
tamilmani1989 reviewed Jan 6, 2024
View reviewed changes
cns/cnireconciler/podinfoprovider_test.go Outdated Show resolved Hide resolved
cns/service/main.go Outdated Show resolved Hide resolved
network/manager.go Outdated Show resolved Hide resolved
@jpayne3506 jpayne3506 changed the title feat: Migration statless cni feat: Migration stateless cni Jan 17, 2024
@behzad-mir behzad-mir force-pushed the Migration-StatlessCNI branch 6 times, most recently from db80e01 to dc29dff Compare January 24, 2024 19:01
jpayne3506
jpayne3506 reviewed Jan 25, 2024
View reviewed changes
cns/client/client.go Outdated Show resolved Hide resolved
cns/cnireconciler/podinfoprovider.go Outdated Show resolved Hide resolved
cns/cnireconciler/podinfoprovider.go Outdated Show resolved Hide resolved
cns/cnireconciler/podinfoprovider.go Outdated Show resolved Hide resolved
cns/cnireconciler/podinfoprovider.go Outdated Show resolved Hide resolved
cns/cnireconciler/podinfoprovider.go Outdated Show resolved Hide resolved
cns/service/main.go Outdated Show resolved Hide resolved
network/endpoint.go Outdated Show resolved Hide resolved
network/endpoint_linux.go Outdated Show resolved Hide resolved
network/endpoint_windows.go Outdated Show resolved Hide resolved
@behzad-mir behzad-mir force-pushed the Migration-StatlessCNI branch 3 times, most recently from aa9c9bb to 195356c Compare January 26, 2024 06:33
vipul-21
vipul-21 reviewed Jan 26, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
network/manager.go Outdated Show resolved Hide resolved
@behzad-mir behzad-mir force-pushed the Migration-StatlessCNI branch 4 times, most recently from 91f9747 to aab2689 Compare January 29, 2024 21:42
@behzad-mir behzad-mir assigned behzad-mir and rbtr and unassigned behzad-mir and rbtr Jan 29, 2024
tamilmani1989
tamilmani1989 reviewed Feb 5, 2024
View reviewed changes
cns/restserver/ipam.go Show resolved Hide resolved
cns/restserver/ipam.go Outdated Show resolved Hide resolved
tamilmani1989
tamilmani1989 previously approved these changes Feb 7, 2024
View reviewed changes
@behzad-mir behzad-mir force-pushed the Migration-StatlessCNI branch from 0e6ba6e to 78f6922 Compare February 8, 2024 00:09
rbtr
rbtr requested changes Feb 8, 2024
View reviewed changes
cns/configuration/configuration.go Outdated Show resolved Hide resolved
cns/restserver/ipam.go Show resolved Hide resolved
cns/cnireconciler/podinfoprovider.go Outdated Show resolved Hide resolved
network/endpoint.go Outdated Show resolved Hide resolved
network/manager.go Show resolved Hide resolved
network/endpoint_linux.go Show resolved Hide resolved
cns/service/main.go Outdated Show resolved Hide resolved
@behzad-mir behzad-mir force-pushed the Migration-StatlessCNI branch from 03fe7ed to ea0be88 Compare February 8, 2024 22:10
rbtr
rbtr requested changes Feb 8, 2024
View reviewed changes
network/endpoint.go Show resolved Hide resolved
cns/service/main.go Outdated Show resolved Hide resolved
cns/service/main.go Show resolved Hide resolved
cns/cnireconciler/podinfoprovider.go Show resolved Hide resolved
@behzad-mir behzad-mir force-pushed the Migration-StatlessCNI branch from ea0be88 to bf4a00e Compare February 8, 2024 23:07
rbtr
rbtr approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remaining suggestions are not blocking

@behzad-mir behzad-mir added this pull request to the merge queue Feb 8, 2024
Merged via the queue into master with commit b22ac38 Feb 9, 2024
15 checks passed
@behzad-mir behzad-mir deleted the Migration-StatlessCNI branch February 9, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpayne3506 jpayne3506 jpayne3506 left review comments

@vipul-21 vipul-21 vipul-21 left review comments

@rbtr rbtr rbtr approved these changes

@tamilmani1989 tamilmani1989 tamilmani1989 left review comments

Assignees
No one assigned
Labels
cni Related to CNI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@behzad-mir @tamilmani1989 @rbtr @vipul-21 @jpayne3506