-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new status to PN CRD #2535
Merged
Merged
Add new status to PN CRD #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarwal0009
requested review from
ZetaoZhuang,
rbtr,
miguelgoms and
thatmattlong
January 22, 2024 22:07
miguelgoms
previously approved these changes
Jan 22, 2024
ZetaoZhuang
previously approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
aggarwal0009
dismissed stale reviews from ZetaoZhuang and miguelgoms
via
January 23, 2024 00:38
4424cd1
aggarwal0009
force-pushed
the
ankaggar/Add-PN-Status
branch
from
January 23, 2024 00:39
4424cd1
to
fbcba7e
Compare
aggarwal0009
commented
Jan 23, 2024
crd/multitenancy/manifests/multitenancy.acn.azure.com_podnetworks.yaml
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
January 23, 2024 17:08
Pull request was converted to draft
miguelgoms
approved these changes
Jan 25, 2024
miguelgoms
approved these changes
Jan 25, 2024
thatmattlong
approved these changes
Jan 25, 2024
alam-tahmid
pushed a commit
that referenced
this pull request
Jan 26, 2024
* Add new status to PN crd * Update PN CRD status * Update PN CRD staus * updating generated manifest for MT podnetwork --------- Co-authored-by: Miguel Gonzalez <miguelgo@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adding a new status to PN CRD to denote failed validation
Issue Fixed:
Requirements:
Notes: