Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new status to PN CRD #2535

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Add new status to PN CRD #2535

merged 6 commits into from
Jan 25, 2024

Conversation

aggarwal0009
Copy link
Contributor

Reason for Change:

Adding a new status to PN CRD to denote failed validation

Issue Fixed:

Requirements:

Notes:

miguelgoms
miguelgoms previously approved these changes Jan 22, 2024
ZetaoZhuang
ZetaoZhuang previously approved these changes Jan 22, 2024
Copy link
Contributor

@ZetaoZhuang ZetaoZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aggarwal0009 aggarwal0009 added this pull request to the merge queue Jan 22, 2024
@thatmattlong thatmattlong removed this pull request from the merge queue due to a manual request Jan 23, 2024
@aggarwal0009 aggarwal0009 dismissed stale reviews from ZetaoZhuang and miguelgoms via 4424cd1 January 23, 2024 00:38
@aggarwal0009 aggarwal0009 force-pushed the ankaggar/Add-PN-Status branch from 4424cd1 to fbcba7e Compare January 23, 2024 00:39
@aggarwal0009 aggarwal0009 marked this pull request as draft January 23, 2024 17:08
auto-merge was automatically disabled January 23, 2024 17:08

Pull request was converted to draft

@miguelgoms miguelgoms marked this pull request as ready for review January 25, 2024 18:33
@miguelgoms miguelgoms self-requested a review January 25, 2024 18:33
@aggarwal0009 aggarwal0009 added this pull request to the merge queue Jan 25, 2024
Merged via the queue into master with commit 8acc551 Jan 25, 2024
14 checks passed
@aggarwal0009 aggarwal0009 deleted the ankaggar/Add-PN-Status branch January 25, 2024 23:59
alam-tahmid pushed a commit that referenced this pull request Jan 26, 2024
* Add new status to PN crd

* Update PN CRD status

* Update PN CRD staus

* updating generated manifest for MT podnetwork

---------

Co-authored-by: Miguel Gonzalez <miguelgo@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants