Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [NPM] Remove TLS Certifications in NPM #2561

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

rayaisaiah
Copy link
Contributor

@rayaisaiah rayaisaiah commented Feb 6, 2024

Reason for Change:
Remove building and publishing NPM images with certs/private keys. The certs are not used but the security scans are flagging this a potential security incident, so we are removing.

Issue Fixed:
Certs are not used.

Requirements:

Notes: Reverted changes made in #1262

@rayaisaiah rayaisaiah requested review from a team as code owners February 6, 2024 19:06
@rayaisaiah rayaisaiah enabled auto-merge February 6, 2024 19:07
@rayaisaiah rayaisaiah changed the title chore: Remove TLS Certifications in NPM chore: [NPM] Remove TLS Certifications in NPM Feb 6, 2024
@rayaisaiah rayaisaiah added npm Related to NPM. linux labels Feb 6, 2024
@rayaisaiah rayaisaiah disabled auto-merge February 6, 2024 19:38
@rayaisaiah rayaisaiah added this pull request to the merge queue Feb 6, 2024
@rayaisaiah rayaisaiah removed this pull request from the merge queue due to a manual request Feb 7, 2024
@rayaisaiah rayaisaiah added this pull request to the merge queue Feb 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2024
@rayaisaiah rayaisaiah added this pull request to the merge queue Feb 7, 2024
Merged via the queue into master with commit ea7e733 Feb 8, 2024
26 of 33 checks passed
@rayaisaiah rayaisaiah deleted the removeNPMCerts branch February 8, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linux npm Related to NPM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants