Add swiftv2 middleware support for standalone service fabric scenario (windows) #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nddq
requested changes
Mar 6, 2024
jaer-tsun
reviewed
Mar 11, 2024
jaer-tsun
reviewed
Mar 11, 2024
jaer-tsun
reviewed
Mar 11, 2024
estebancams
reviewed
Mar 18, 2024
kmurudi
force-pushed
the
Singularity_SwiftV2SFMiddleware
branch
from
18fb031 to
4b58ac6
Compare
timraymond
reviewed
Mar 19, 2024
nddq
requested changes
Mar 20, 2024
|
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
estebancams
reviewed
Apr 11, 2024
3 tasks
msvik
reviewed
May 8, 2024
msvik
reviewed
May 8, 2024
kmurudi
commented
May 16, 2024
kmurudi
commented
May 16, 2024
kmurudi
commented
May 16, 2024
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Pipelines were unable to run due to time out waiting for the pull request to finish merging. |
msvik
approved these changes
Jul 1, 2024
nddq
reviewed
Jul 1, 2024
nddq
approved these changes
Jul 3, 2024
tamilmani1989
approved these changes
Jul 9, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
L1VH/Singularity & Swiftv2 need to program secondary nics for creating pod via containerd. Changes have been supported for AKS pod scenario, but this PR adds support for windows Service fabric/standalone scenario as it gets the data from DNC goal state.
Requirements:
Notes: