backport: ci: remove logger field from portforwarder to avoid race with goroutine (#2959) #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QxBytes
added
cni
jpayne3506
approved these changes
Dec 12, 2024
|
Waiting for fix in #3263 before queuing. Will need to rebase. |
…ne (#2959) * do not pass testing logger into goroutine to avoid race * fix port forwarder
QxBytes
force-pushed
the
alew/backport-portforward-race-fix-1-4
branch
from
a6e3976 to
6ffa33d
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not pass testing logger into goroutine to avoid race
fix port forwarder
Reason for Change:
Backports #2959
Issue Fixed:
Requirements:
Notes: