Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProvisioningDeviceClient.registerDeviceSync(AdditionalData additionalData) - AdditionalData is not getting passed. #1731

Closed
abhiramk139 opened this issue Jul 20, 2023 · 2 comments
Closed

ProvisioningDeviceClient.registerDeviceSync(AdditionalData additionalData) - AdditionalData is not getting passed. #1731

abhiramk139 opened this issue Jul 20, 2023 · 2 comments
Labels
bug fix checked in Fix checked into main or preview, but not yet released. IoTSDK

Comments

@abhiramk139
Copy link

Description: In ProvisioningDeviceClient class the additional data attribute that we are passing is not getting set in ProvisioningDeviceClientConfig object. Since the additional data payload is not getting send to the custom allocation function/ policy.

This issue is there only for synchronous registration of devices. Asynchronous calls are working fine.
@abhiramk139 abhiramk139 changed the title ProvisioningDeviceClient.registerDeviceSync(AdditionalData additionalData) - AdditionalData is not getting paased. ProvisioningDeviceClient.registerDeviceSync(AdditionalData additionalData) - AdditionalData is not getting passed. Jul 20, 2023
timtay-microsoft added a commit that referenced this issue Jul 20, 2023
@timtay-microsoft
fix(prov-dev): Fix bug where sync overload of register ignores additi…
9e456db 
…onal data

#1731
@timtay-microsoft timtay-microsoft mentioned this issue Jul 20, 2023
Merged
@timtay-microsoft
Copy link
Member

Looks like you are correct. #1732 will fix this

timtay-microsoft added a commit that referenced this issue Jul 21, 2023
@timtay-microsoft
fix(prov-dev): Fix bug where sync overload of register ignores additi…
b273bcc 
…onal data (#1732)

#1731
@timtay-microsoft timtay-microsoft added the fix checked in Fix checked into main or preview, but not yet released. label Jul 21, 2023
@timtay-microsoft
Copy link
Member

This issue has been fixed as of version 2.1.1, so I'm closing this thread.

https://github.com/Azure/azure-iot-sdk-java/releases/tag/2023-07-25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fix checked in Fix checked into main or preview, but not yet released. IoTSDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timtay-microsoft @abhiramk139