Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAS token expiry time values needs an upper boundry #1744

Closed
timtay-microsoft opened this issue Oct 9, 2023 · 1 comment
Closed

SAS token expiry time values needs an upper boundry #1744

timtay-microsoft opened this issue Oct 9, 2023 · 1 comment
Assignees

Comments

@timtay-microsoft
Copy link
Member

Setting a SAS token expiry time of 40 years and connecting over AMQP leads to some kind of integer overflow that causes SAS tokens to be sent to the service rapidly. Because of that, we should probably add some SDK-side check that prevents any values that would cause this kind of overflow.

Still TBD what happens over MQTT or HTTP

@timtay-microsoft
Copy link
Member Author

Version 2.3.1 has been released with this fix, so I'll close this thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant