Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue: QOS not set for incoming messages from $iothub/twin/PAT… #1747

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Fixing issue: QOS not set for incoming messages from $iothub/twin/PAT… #1747

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f18b9c
Fixing issue: QOS not set for incoming messages from $iothub/twin/PAT…
dzakub Oct 12, 2023
7b45793
Update iothub/device/iot-device-client/src/main/java/com/microsoft/az…
dzakub Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...vice-client/src/main/java/com/microsoft/azure/sdk/iot/device/transport/mqtt/MqttTwin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,7 @@ else if (topic.length() > PATCH.length() && topic.startsWith(PATCH))
{
message = new IotHubTransportMessage(data, MessageType.DEVICE_TWIN);
message.setDeviceOperationType(DeviceOperations.DEVICE_OPERATION_TWIN_SUBSCRIBE_DESIRED_PROPERTIES_RESPONSE);
message.setQualityOfService(messagePair.getValue().getQos());
dzakub marked this conversation as resolved.
Show resolved Hide resolved
}

// Case for $iothub/twin/PATCH/properties/desired/?$version={new version}
Expand Down
27 changes: 27 additions & 0 deletions ...-client/src/test/java/com/microsoft/azure/sdk/iot/device/transport/mqtt/MqttTwinTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,6 +904,33 @@ public void receiveDoesNotSetVersionForDesiredPropNotifRespIfNotFound() throws T
}
}

@Test
public void receiveSetQosForDesiredProp() throws TransportException
{
final byte[] actualPayload = "NotificationResponseDataContainingDesiredPropertiesDocument".getBytes(StandardCharsets.UTF_8);
final String expectedTopic = "$iothub/twin/PATCH/properties/desired/";
IotHubTransportMessage receivedMessage = null;
int expectedQualityOfService = 2;
timtay-microsoft marked this conversation as resolved.
Show resolved Hide resolved
try
{
//arrange
Queue<Pair<String, MqttMessage>> testreceivedMessages = new ConcurrentLinkedQueue<>();
MqttMessage mqttMessage = new MqttMessage(actualPayload);
mqttMessage.setQos(expectedQualityOfService);
testreceivedMessages.add(new MutablePair<>(expectedTopic, mqttMessage));
MqttTwin testTwin = new MqttTwin("", mockedConnectOptions, new HashMap<>(), testreceivedMessages);

//act
receivedMessage = testTwin.receive();
}
finally
{
//assert
assertNotNull(receivedMessage);
assertEquals(expectedQualityOfService, receivedMessage.getQualityOfService());
}
}

/*
**Tests_SRS_MQTTDEVICETWIN_25_042: [If the topic is of type patch for desired properties then this method shall parse further to look for version which if found is set by calling setVersion]
*/
Expand Down