fix(iot-dev): Fix 3 multiplexing scenario bugs #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix bug where a closing multiplexed device would report its state as ```Disconnected``` followed by ```Disconnected_retrying``` and then finally ```Disconnected``` - Fix bug where a multiplexed device that has its device session closed didn't cancel all of its outgoing messages
timtay-microsoft
requested review from
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft and
patilsnr
as code owners
| @@ -1388,6 +1390,7 @@ private void singleDeviceReconnectAttemptAsync(String deviceSessionToReconnect) | |||
| { | |||
| this.updateStatus(IotHubConnectionStatus.DISCONNECTED, IotHubConnectionStatusChangeReason.RETRY_EXPIRED, transportException, deviceSessionToReconnect); | |||
| log.debug("Reconnection for device {} was abandoned due to the operation timeout", deviceSessionToReconnect); | |||
| return; | |||
There was a problem hiding this comment.
Not returning here meant that retry logic would continue even if we declare that retry has expired
timtay-microsoft
changed the title
| @@ -1766,6 +1771,55 @@ private void updateStatus(IotHubConnectionStatus newConnectionStatus, IotHubConn | |||
| else if (newConnectionStatus == IotHubConnectionStatus.DISCONNECTED) | |||
| { | |||
| correlationCallbackCleanupThread.interrupt(); | |||
| finalizeMultiplexedDevicesMessages(deviceId); | |||
There was a problem hiding this comment.
Now when a multiplexed device reaches the DISCONNECTED state, we look for any of its messages in the outgoing queues and cancel them. This should address #1734
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
andyk-ms
approved these changes
Oct 20, 2023
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disconnectedfollowed byDisconnected_retryingand then finallyDisconnected