-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Melinda/clean #100
Melinda/clean #100
Conversation
I think you need to rebase this change. Also, can you change the code so that there is no build warnings. D:\z\azure-media-migration\ams\CleanupCommand.cs(44,44): warning CS8625: Cannot convert null literal to non-nullable reference type. [D:\z\azure-media-migration\AMSMigrate.csproj] |
ams/CleanupCommand.cs
Outdated
await liveEvent.DeleteAsync(WaitUntil.Completed); | ||
} | ||
} | ||
_logger.LogDebug("account {account} is deleted.", account.Data.Name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This log can be reported after CleanupAccountAsync( ) is called, or just move the lines between 74 and 99 into function CleanupAccountAsync( ).
#86
Add clean up account command:
"--source-account-name", "-n"
"--resource-filter", "-f"
"--cleanup-type", "-t"
"--force-cleanup", "-x"
"--cleanup-account", "-ax"