Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Melinda/clean #100

Merged
merged 11 commits into from
Aug 2, 2023
Merged

Melinda/clean #100

merged 11 commits into from
Aug 2, 2023

Conversation

melindawangmsft
Copy link
Collaborator

#86
Add clean up account command:
"--source-account-name", "-n"
"--resource-filter", "-f"
"--cleanup-type", "-t"
"--force-cleanup", "-x"
"--cleanup-account", "-ax"

AssetOptionsBinder.cs Outdated Show resolved Hide resolved
StorageOptionsBinder.cs Outdated Show resolved Hide resolved
@pohhsu
Copy link
Collaborator

pohhsu commented Jul 31, 2023

I think you need to rebase this change. Also, can you change the code so that there is no build warnings.

D:\z\azure-media-migration\ams\CleanupCommand.cs(44,44): warning CS8625: Cannot convert null literal to non-nullable reference type. [D:\z\azure-media-migration\AMSMigrate.csproj]
D:\z\azure-media-migration\CleanupOptionsBinder.cs(68,17): warning CS8604: Possible null reference argument for parameter 'AccountName' in 'CleanupOptions.CleanupOptions(string Accou
ntName, CleanupType CleanupType, string? ResourceFilter, bool IsForceCleanUpAsset, bool IsCleanUpAccount)'. [D:\z\azure-media-migration\AMSMigrate.csproj]

CleanupOptionsBinder.cs Outdated Show resolved Hide resolved
CleanupOptionsBinder.cs Outdated Show resolved Hide resolved
ams/AssetMigrator.cs Outdated Show resolved Hide resolved
CleanupOptionsBinder.cs Outdated Show resolved Hide resolved
ams/CleanupCommand.cs Outdated Show resolved Hide resolved
ams/CleanupCommand.cs Outdated Show resolved Hide resolved
ams/CleanupCommand.cs Outdated Show resolved Hide resolved
ams/CleanupCommand.cs Outdated Show resolved Hide resolved
Program.cs Show resolved Hide resolved
ams/CleanupCommand.cs Outdated Show resolved Hide resolved
ams/CleanupCommand.cs Outdated Show resolved Hide resolved
ams/CleanupCommand.cs Outdated Show resolved Hide resolved
ams/CleanupCommand.cs Outdated Show resolved Hide resolved
ams/CleanupCommand.cs Outdated Show resolved Hide resolved
ams/CleanupCommand.cs Outdated Show resolved Hide resolved
ams/CleanupCommand.cs Outdated Show resolved Hide resolved
ams/CleanupCommand.cs Outdated Show resolved Hide resolved
ams/CleanupCommand.cs Outdated Show resolved Hide resolved
ams/CleanupCommand.cs Outdated Show resolved Hide resolved
ams/CleanupCommand.cs Outdated Show resolved Hide resolved
await liveEvent.DeleteAsync(WaitUntil.Completed);
}
}
_logger.LogDebug("account {account} is deleted.", account.Data.Name);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This log can be reported after CleanupAccountAsync( ) is called, or just move the lines between 74 and 99 into function CleanupAccountAsync( ).

@melindawangmsft melindawangmsft merged commit f6fe34e into main Aug 2, 2023
1 of 2 checks passed
@melindawangmsft melindawangmsft deleted the melinda/clean branch August 2, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants