Ensure the source media files are not directly copied over to destina… #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion if it is handled by packager Description: The TranformFactory might contain more transforms, PackagerTransform and UploadTransform. But usually only one transform is needed for a specific source asset. When the source asset contains .ism, it is supposed to be handled by the PackagerTransform. When the source asset doesn't have .ism, it is UploadTransform's job to copy over media files. Each Transform instance has its own logic to determine what type of source asset can be supported by this transform. If a previous transform doesn't support such input asset, it returns status as Skipped, The next transform is invoked only when previous transform reports Skipped. Make sure the outputPath reported by all these transforms follow the same spec, which points to the destination folder only.
pohhsu
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion if it is handled by packager
Description:
The TranformFactory might contain more transforms, PackagerTransform and UploadTransform.
But usually only one transform is needed for a specific source asset.
When the source asset contains .ism, it is supposed to be handled by the PackagerTransform.
When the source asset doesn't have .ism, it is UploadTransform's job to copy over media files.
Each Transform instance has its own logic to determine what type of source asset can be supported by this transform.
If a previous transform doesn't support such input asset, it returns status as Skipped,
The next transform is invoked only when previous transform reports Skipped.
Make sure the outputPath reported by all these transforms follow the same spec, which points to the destination folder only.