Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardization on param usage for failingPeriods and evaluationPeriods #362

Merged
merged 14 commits into from
Oct 15, 2024
Merged

Standardization on param usage for failingPeriods and evaluationPeriods #362

merged 14 commits into from
Oct 15, 2024

Conversation

Brunoga-MS
Copy link
Contributor

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Make use of parameters for failingPeriods and evaluationPeriods settings instead of hardcoded values
image

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Brunoga-MS Brunoga-MS added Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments labels Oct 5, 2024
@arjenhuitema arjenhuitema self-assigned this Oct 9, 2024
arjenhuitema
arjenhuitema approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema merged commit e3c2cee into Azure:main Oct 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjenhuitema arjenhuitema arjenhuitema approved these changes

Assignees

@arjenhuitema arjenhuitema

Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brunoga-MS @arjenhuitema