Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 1.5.1 breaking change (maybe) #63

Closed
tssdavey opened this issue Jan 12, 2024 · 11 comments · May be fixed by #61
Closed

🪲 1.5.1 breaking change (maybe) #63

tssdavey opened this issue Jan 12, 2024 · 11 comments · May be fixed by #61
Assignees
Labels
bug Something isn't working Needs: Author Feedback 👂 Needs the author to provide feedback Status: In PR

Comments

@tssdavey
Copy link

Describe the bug

I get this error when using version 1.5.1

{
    "status": "Failed",
    "error": {
        "code": "DeploymentFailed",
        "target": "/providers/Microsoft.Management/managementGroups/xenia-corp/providers/Microsoft.Resources/deployments/shared-services",
        "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.",
        "details": [
            {
                "code": "ResourceDeploymentFailure",
                "target": "/providers/Microsoft.Management/managementGroups/xenia-corp/providers/Microsoft.Resources/deployments/lz-vend-sub-res-create-shared-services-i7ug2kbzlb7vc",
                "message": "The resource write operation failed to complete successfully, because it reached terminal provisioning state 'Failed'.",
                "details": [
                    {
                        "code": "DeploymentOutputEvaluationFailed",
                        "target": "/providers/Microsoft.Management/managementGroups/xenia-corp/providers/Microsoft.Resources/deployments/lz-vend-sub-res-create-shared-services-i7ug2kbzlb7vc",
                        "message": "Unable to evaluate template outputs: 'failedFeatures'. Please see error details and deployment operations. Please see https://aka.ms/arm-common-errors for usage details.",
                        "details": [
                            {
                                "code": "DeploymentOutputEvaluationFailed",
                                "target": "failedFeatures",
                                "message": "The template output 'failedFeatures' is not valid: The language expression property 'failedFeaturesRegistrations' doesn't exist, available properties are 'failedProvidersRegistrations'.."
                            }
                        ]
                    }
                ]
            }
        ]
    }
}

To Reproduce

Steps to reproduce the behaviour:

targetScope = 'managementGroup'

module subscriptionmod 'br/public:lz/sub-vending:1.5.1' = {
  name: '<my-name>'
  params: {
    subscriptionAliasEnabled: true
    subscriptionBillingScope: '<my billing scope>'
    subscriptionAliasName: '<my-name>'
    subscriptionDisplayName: '<my-name>'
    subscriptionWorkload: 'Production'
    subscriptionManagementGroupAssociationEnabled: true
    subscriptionManagementGroupId: '<my-mg>'
  }
}

results in above error

module subscriptionmod 'br/public:lz/sub-vending:1.4.1' = {
  name: '<my-name>'
  params: {
    subscriptionAliasEnabled: true
    subscriptionBillingScope: '<my billing scope>'
    subscriptionAliasName: '<my-name>'
    subscriptionDisplayName: '<my-name>'
    subscriptionWorkload: 'Production'
    subscriptionManagementGroupAssociationEnabled: true
    subscriptionManagementGroupId: '<my-mg>'
  }
}

results in successful deployment

Additional context

I'm happy to try and look into this one myself

@tssdavey tssdavey added the bug Something isn't working label Jan 12, 2024
@jtracey93
Copy link
Collaborator

Thanks for raising @tssdavey.

Can you confirm what bicep version you have installed? Are you on the latest?

az bicep version
bicep --version

Note it can be installed side-by-side so you need to check and ensure both are up-to-date

image

@jtracey93 jtracey93 added the Needs: Author Feedback 👂 Needs the author to provide feedback label Jan 12, 2024
@jtracey93 jtracey93 changed the title 🪲 1.5.1 breaking change 🪲 1.5.1 breaking change (maybe) Jan 12, 2024
@tssdavey
Copy link
Author

0.24.24
image

@sebassem sebassem linked a pull request Jan 14, 2024 that will close this issue
8 tasks
@sebassem
Copy link
Contributor

@tssdavey Thanks for submitting this issue, it should be fixed in the assigned PR.

@MilesCameron-DMs
Copy link
Contributor

MilesCameron-DMs commented Jan 21, 2024

I am also seeing this issue but via a GitHub runner which is using the latest version v0.24.24

@dburlinson
Copy link

I am having the same issue. The sooner this PR can fix the better.

@sebassem
Copy link
Contributor

We are working to merge this asap. Not to get you blocked, you can just replace Invoke-RegisterSubscriptionResourceProviders.ps1 with the version in the PR to get this resolved.

@PierreCo31
Copy link

Still having the issue, is this module still maintained since the move to AVM ?

@jtracey93
Copy link
Collaborator

This is indeed maintained. We are so close to getting the AVM module out with this fix in.

Cc: @sebassem

@Zalmez
Copy link

Zalmez commented Jun 7, 2024

Any ETA when the branch will be merged?

@sebassem
Copy link
Contributor

sebassem commented Jun 7, 2024

ETA is mid-ext week, we are pending final reviews from the AVM team.

@sebassem
Copy link
Contributor

we have finally published the AVM module for sub-vending, thanks for your patience. Please review the announcement here on how to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs: Author Feedback 👂 Needs the author to provide feedback Status: In PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants