Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add key uri outputs to keyvault key submodule - avm/res/key-vault/vault #3246

Conversation

Gosselin-l
Copy link

Description

Added 2 more outputs to the Keyvault Key submodule:

  • keyUri
  • keyUriWithVersion

These outputs can then be used by other modules (eg: AzureSQL, to encrypt server/databases)

Pipeline Reference

Pipeline

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@Gosselin-l Gosselin-l requested review from a team as code owners September 10, 2024 16:03
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Sep 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Sep 10, 2024
@fblix
Copy link
Contributor

fblix commented Sep 10, 2024

Hi @Gosselin-l, thanks for the PR. Can you do me a favor and attach a successful pipeline run to your PR, that shows that your changes don't contradict with any guidelines we have in AVM?

Thanks!

@matebarabas matebarabas changed the title feat: Add key uri outputs to keyvault key submodule feat: Add key uri outputs to keyvault key submodule - avm/res/key-vault/vault Sep 18, 2024
@@ -150,6 +150,12 @@ resource key_roleAssignments 'Microsoft.Authorization/roleAssignments@2022-04-01
}
]

@description('The uri of the key.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fblix sorry to chime in on one point, then I'll leave the PR review to you.

@Gosselin-l please also update the minor version in the version.json file, since a new output is added functionality for the module. Thanks!

@eriqua eriqua added Class: Resource Module 📦 This is a resource module Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author and removed Needs: Triage 🔍 Maintainers need to triage still labels Sep 28, 2024
@AlexanderSehr AlexanderSehr linked an issue Oct 1, 2024 that may be closed by this pull request
1 task
@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented Oct 1, 2024

Hey @Gosselin-l,
could you update the parent key-vault module as per my comment in the linked issue #3245 too? If it's too complicated that's fine, then I'll unassign the issue again, but it would certainly be great to have the change implemented if possible :)

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Oct 1, 2024
@eriqua eriqua added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Oct 1, 2024
@ReneHezser
Copy link
Contributor

ReneHezser commented Oct 4, 2024

@Gosselin-l
We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.

Please reach out if any support is needed.

Update: not needed, as this PR does not affect the the main bicep and tests

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Oct 4, 2024
@eriqua eriqua added Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Oct 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Oct 11, 2024
@AlexanderSehr
Copy link
Contributor

Closing if favor of #3603
@Gosselin-l will remain the author of the changes in the git history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: add more outputs to the key submodule
5 participants