-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add key uri outputs to keyvault key submodule - avm/res/key-vault/vault
#3246
feat: Add key uri outputs to keyvault key submodule - avm/res/key-vault/vault
#3246
Conversation
Hi @Gosselin-l, thanks for the PR. Can you do me a favor and attach a successful pipeline run to your PR, that shows that your changes don't contradict with any guidelines we have in AVM? Thanks! |
avm/res/key-vault/vault
@@ -150,6 +150,12 @@ resource key_roleAssignments 'Microsoft.Authorization/roleAssignments@2022-04-01 | |||
} | |||
] | |||
|
|||
@description('The uri of the key.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fblix sorry to chime in on one point, then I'll leave the PR review to you.
@Gosselin-l please also update the minor version in the version.json file, since a new output is added functionality for the module. Thanks!
Hey @Gosselin-l, |
@Gosselin-l Please reach out if any support is needed. Update: not needed, as this PR does not affect the the main bicep and tests |
Closing if favor of #3603 |
Description
Added 2 more outputs to the Keyvault Key submodule:
These outputs can then be used by other modules (eg: AzureSQL, to encrypt server/databases)
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.