-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add UDT to avm/res/operational-insights/workspace
#3774
base: main
Are you sure you want to change the base?
Conversation
…into users/krbar/lawUDT
metaData: destinationMetaDataType? | ||
} | ||
|
||
@export() | ||
type destinationMetaDataType = { | ||
@description('Optional. Allows to define an Event Hub name. Not applicable when destination is Storage Account.') | ||
eventHubName: string? | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metaData: destinationMetaDataType? | |
} | |
@export() | |
type destinationMetaDataType = { | |
@description('Optional. Allows to define an Event Hub name. Not applicable when destination is Storage Account.') | |
eventHubName: string? | |
} | |
metaData: { | |
@description('Optional. Allows to define an Event Hub name. Not applicable when destination is Storage Account.') | |
eventHubName: string? | |
}? | |
} |
If only used in one location why 2 types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to adopt this suggestion, the same comment applies to all other types. If not, nevermind. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged these two types into one, but somehow I overlooked your commitable suggestion and made the same change on my own.... 🤷♂️
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…into users/krbar/lawUDT
Hey @krbar , Firstly, thanks for your work on this PR! We have made some changes to the AVM CI, detailed below, which means we need you to update your fork to pull in these latest changes and re-run your tests to show they still are passing prior to approving and merging this PR, as we don't and it fails once merged the publishing of your module will fail and will be blocked going forward until the test pass again via additional PRs. Changes to CI That Have Been Made That You Need To Take Action On
Any questions reach out to the AVM Core Team by tagging us in your PR here or internally via Teams Thanks Jack (AVM Core Team) |
…into users/krbar/lawUDT
Thanks @jtracey93 the PR is updated and the module passes the validation. There was also an update of Bicep so the README/ARM files had to be re-generated too. |
Description
Add User Defined Types to the Log Analytics Workspace module.
Also fixes #3798
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.