Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add UDT to avm/res/operational-insights/workspace #3774

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Nov 12, 2024

Description

Add User Defined Types to the Log Analytics Workspace module.
Also fixes #3798

Pipeline Reference

Pipeline
avm.res.operational-insights.workspace

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@krbar krbar self-assigned this Nov 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Nov 12, 2024
@krbar krbar marked this pull request as ready for review November 13, 2024 00:28
@krbar krbar requested review from a team as code owners November 13, 2024 00:28
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Nov 13, 2024
Comment on lines 67 to 74
metaData: destinationMetaDataType?
}

@export()
type destinationMetaDataType = {
@description('Optional. Allows to define an Event Hub name. Not applicable when destination is Storage Account.')
eventHubName: string?
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
metaData: destinationMetaDataType?
}
@export()
type destinationMetaDataType = {
@description('Optional. Allows to define an Event Hub name. Not applicable when destination is Storage Account.')
eventHubName: string?
}
metaData: {
@description('Optional. Allows to define an Event Hub name. Not applicable when destination is Storage Account.')
eventHubName: string?
}?
}

If only used in one location why 2 types?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to adopt this suggestion, the same comment applies to all other types. If not, nevermind. 😄

Copy link
Contributor Author

@krbar krbar Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged these two types into one, but somehow I overlooked your commitable suggestion and made the same change on my own.... 🤷‍♂️

@jtracey93
Copy link
Contributor

Hey @krbar ,

Firstly, thanks for your work on this PR!

We have made some changes to the AVM CI, detailed below, which means we need you to update your fork to pull in these latest changes and re-run your tests to show they still are passing prior to approving and merging this PR, as we don't and it fails once merged the publishing of your module will fail and will be blocked going forward until the test pass again via additional PRs.

Changes to CI That Have Been Made That You Need To Take Action On

Any questions reach out to the AVM Core Team by tagging us in your PR here or internally via Teams

Thanks

Jack (AVM Core Team)

@krbar
Copy link
Contributor Author

krbar commented Nov 15, 2024

Thanks @jtracey93 the PR is updated and the module passes the validation. There was also an update of Bicep so the README/ARM files had to be re-generated too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] avm.res.operational-insights.workspace
3 participants