Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated What-If Step #86

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

Updated What-If Step #86

wants to merge 32 commits into from

Conversation

marvinbuss
Copy link
Collaborator

@marvinbuss marvinbuss commented Nov 24, 2021

Summary of the Pull Request

Update to new what-if deployment task (https://github.com/Azure/arm-deploy/releases/tag/v1.0.6) and switching to bicep deployment.

References

None

PR Checklist

  • CLA signed. If not, go over here and sign the CLA

Validation Steps Performed

Please see checks below.

@marvinbuss marvinbuss added feature Feature Requests committed Committed item labels Nov 24, 2021
@marvinbuss marvinbuss added this to the v1.2.0 milestone Nov 24, 2021
@marvinbuss marvinbuss self-assigned this Nov 24, 2021
@marvinbuss marvinbuss requested a review from a team as a code owner November 24, 2021 08:12
@ghost ghost added the review Review required for pull request label Nov 24, 2021
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghost ghost removed the review Review required for pull request label Nov 24, 2021
@marvinbuss marvinbuss marked this pull request as draft November 24, 2021 08:33
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

amanjeetsingh
amanjeetsingh previously approved these changes Nov 29, 2021
@marvinbuss marvinbuss marked this pull request as ready for review December 7, 2021 15:23
@marvinbuss marvinbuss marked this pull request as draft December 7, 2021 15:23
@marvinbuss marvinbuss modified the milestones: v1.2.0, v1.3.0 Dec 20, 2021
amanjeetsingh
amanjeetsingh previously approved these changes Dec 23, 2021
@marvinbuss marvinbuss temporarily deployed to dev March 4, 2022 17:32 Inactive
@marvinbuss marvinbuss temporarily deployed to dev March 4, 2022 17:35 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
committed Committed item feature Feature Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants