Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interface: use the annotation to support serviceExport weight #247

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

zhiying-lin
Copy link
Contributor

What type of PR is this?
/kind api-change

What this PR does / why we need it:
As discussed, since the exportedLabel and exportedAnnotation are used for the derived service.
We'll put the weight on the serviceExport annotation instead.

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.14%. Comparing base (f98e10e) to head (54d62ea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   79.88%   80.14%   +0.25%     
==========================================
  Files          28       28              
  Lines        3863     3863              
==========================================
+ Hits         3086     3096      +10     
+ Misses        620      611       -9     
+ Partials      157      156       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanzhang-oss ryanzhang-oss merged commit b0a85d0 into Azure:main Jan 14, 2025
10 checks passed
@zhiying-lin zhiying-lin deleted the fix-api branch January 15, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants