diff --git a/.github/workflows/approval-comment.yaml b/.github/workflows/approval-comment.yaml new file mode 100644 index 000000000..dd9aab2f8 --- /dev/null +++ b/.github/workflows/approval-comment.yaml @@ -0,0 +1,13 @@ +name: ApprovalComment +on: + pull_request_review: + types: [submitted] + +jobs: + approval-comment: + if: startsWith(github.event.review.body, '/e2e') + runs-on: ubuntu-latest + steps: + - name: run e2e + run: | + echo "run e2e" \ No newline at end of file diff --git a/.github/workflows/e2e-matrix-trigger.yaml b/.github/workflows/e2e-matrix-trigger.yaml index 816c12aec..36bc5d982 100644 --- a/.github/workflows/e2e-matrix-trigger.yaml +++ b/.github/workflows/e2e-matrix-trigger.yaml @@ -15,4 +15,4 @@ jobs: secrets: E2E_CLIENT_ID: ${{ secrets.E2E_CLIENT_ID }} E2E_TENANT_ID: ${{ secrets.E2E_TENANT_ID }} - E2E_SUBSCRIPTION_ID: ${{ secrets.E2E_SUBSCRIPTION_ID }} + E2E_SUBSCRIPTION_ID: ${{ secrets.E2E_SUBSCRIPTION_ID }} \ No newline at end of file diff --git a/pkg/utils/opts/armopts.go b/pkg/utils/opts/armopts.go index 68e5834d9..75ff4bc4e 100644 --- a/pkg/utils/opts/armopts.go +++ b/pkg/utils/opts/armopts.go @@ -18,7 +18,6 @@ package opts import ( "net/http" - "time" "github.com/Azure/azure-sdk-for-go/sdk/azcore/arm" "github.com/Azure/azure-sdk-for-go/sdk/azcore/policy" @@ -35,21 +34,11 @@ func DefaultArmOpts() *arm.ClientOptions { func DefaultRetryOpts() policy.RetryOptions { return policy.RetryOptions{ - MaxRetries: 20, - // Note the default retry behavior is exponential backoff - RetryDelay: time.Second * 5, - // TODO: bsoghigian: Investigate if we want to leverage some of the status codes other than the defaults. - // the defaults are // StatusCodes specifies the HTTP status codes that indicate the operation should be retried. - // A nil slice will use the following values. - // http.StatusRequestTimeout 408 - // http.StatusTooManyRequests 429 - // http.StatusInternalServerError 500 - // http.StatusBadGateway 502 - // http.StatusServiceUnavailable 503 - // http.StatusGatewayTimeout 504 - // Specifying values will replace the default values. - // Specifying an empty slice will disable retries for HTTP status codes. - // StatusCodes: nil, + // MaxRetries specifies the maximum number of attempts a failed operation will be retried + // before producing an error. + // The default value is three. A value less than zero means one try and no retries. + // See Reference here: https://github.com/Azure/azure-sdk-for-go/blob/v61.4.0/sdk/azcore/policy/policy.go#L73 + MaxRetries: -1, } }