Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): cleanup improvements #443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/pkg/environment/common/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ var (
&schedulingv1.PriorityClass{},
&v1.Node{},
&corev1beta1.NodeClaim{},

// AKSNodeClass here breaks provider separation
// but may help with cascading foreground cleanup
&v1alpha2.AKSNodeClass{},
}
)

Expand Down Expand Up @@ -128,7 +132,9 @@ func (env *Environment) CleanupObjects(cleanableObjects ...client.Object) {
// are deleting so that we avoid getting client-side throttled
workqueue.ParallelizeUntil(env, 50, len(metaList.Items), func(i int) {
defer GinkgoRecover()
g.Expect(client.IgnoreNotFound(env.Client.Delete(env, &metaList.Items[i], client.PropagationPolicy(metav1.DeletePropagationForeground)))).To(Succeed())
g.Expect(client.IgnoreNotFound(env.Client.Delete(env, &metaList.Items[i],
client.PropagationPolicy(metav1.DeletePropagationForeground),
&client.DeleteOptions{GracePeriodSeconds: lo.ToPtr(int64(0))}))).To(Succeed())
})
// If the deletes eventually succeed, we should have no elements here at the end of the test
g.Expect(env.Client.List(env, metaList, client.HasLabels([]string{test.DiscoveryLabel}), client.Limit(1))).To(Succeed())
Expand Down
Loading