fix: removing --keep-terminated-pod-volumes from kubelet flags and adding k8s 1.31 to ci-test #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bryce-Soghigian
changed the title
|
This can't be properly tested until upstream images are replicated to our acs upstream mirror. As we can't bootstrap nodes with 1.31 until we have those images published. |
…umes on older k8s versions
…envtest 1.31 binaries
Pull Request Test Coverage Report for Build 10380206199Details
💛 - Coveralls |
Bryce-Soghigian
added a commit
that referenced
this pull request
Sep 12, 2024
…ding k8s 1.31 to ci-test (#455) * fix: removing --keep-terminated-pod-volumes from kubelet flags * fix: test updating case to properly get the --keep-terminated-pod-volumes on older k8s versions * fix: removing print statement * test: upgrading controller-runtime/tools/envtest to leverage the new envtest 1.31 binaries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
For supporting 1.31 node bootstrapping, we need to remove the
--keep-terminated-pod-volumesfrom the kubelet flags. This pr introduces that logic into our bootstrapping contract.How was this change tested?
Does this change impact docs?
Release Note