Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add dl.k8s.io to egress policy allowlist for toolchain #533

Merged
merged 5 commits into from
Oct 19, 2024
Merged

ci: add dl.k8s.io to egress policy allowlist for toolchain #533

merged 5 commits into from
Oct 19, 2024

Conversation

comtalyst
Copy link
Collaborator

Fixes #

Description
This is being used in toolchain (for 1.25 CI pipeline only). Need to add it to allow list.

How was this change tested?

  • CI

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

@coveralls
Copy link

coveralls commented Oct 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11413562865

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.866%
Totals Coverage Status
Change from base Build 11398977564: 0.0%
Covered Lines: 36318
Relevant Lines: 37110
💛 - Coveralls

tallaxes
tallaxes previously approved these changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@tallaxes tallaxes added area/security Issues or PRs related to security area/ci Issues or PRs related to ci labels Oct 19, 2024
@tallaxes tallaxes merged commit eb5326e into main Oct 19, 2024
12 checks passed
@tallaxes tallaxes deleted the robin/add-1.25-ci-url-to-egress-allow branch October 19, 2024 05:32
@tallaxes tallaxes mentioned this pull request Oct 23, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallaxes tallaxes tallaxes approved these changes

Assignees

@comtalyst comtalyst

Labels
area/ci Issues or PRs related to ci area/security Issues or PRs related to security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@comtalyst @coveralls @tallaxes