Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updates golangci-lint to v1.52.2 #212

Merged
merged 1 commit into from
Apr 11, 2023
Merged

chore: updates golangci-lint to v1.52.2 #212

merged 1 commit into from
Apr 11, 2023

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Apr 11, 2023

Reason for Change:

Issue Fixed:

Notes for Reviewers:

@nilekhc nilekhc requested a review from aramase as a code owner April 11, 2023 21:09
@aramase aramase changed the title chore: updates lint chore: updates golangci-lint to v1.52.2 Apr 11, 2023
aramase
aramase requested changes Apr 11, 2023
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integration tests failed because the credentials used expired. I've rotated it.

pkg/plugin/server.go Outdated Show resolved Hide resolved
@nilekhc
chore: updates lint
ddac9d8 
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc nilekhc merged commit e4f695b into Azure:master Apr 11, 2023
@nilekhc nilekhc deleted the update-linter branch April 11, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramase aramase aramase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilekhc @aramase