Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bastionnsg and remove allowedvalues to fix invalidtype error #1050

Merged
merged 11 commits into from
Jul 5, 2024

Conversation

jayhaddad
Copy link
Contributor

@jayhaddad jayhaddad commented Jun 21, 2024

Description

  1. Added nsg for bastion subnet
  2. Removed allowedValues check on deployDefenderPlans array

Issue reference

The issue this PR will close: #930 #986

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@jayhaddad jayhaddad requested a review from a team as a code owner June 21, 2024 02:15
@jayhaddad jayhaddad linked an issue Jun 21, 2024 that may be closed by this pull request
@jamasten
Copy link
Contributor

jamasten commented Jul 5, 2024

Verified the NSG rules with: https://learn.microsoft.com/en-us/azure/bastion/bastion-nsg#apply
image
Successfully deployed the branch:
image
Successfully connected to the remote access VM using bastion
Verified the NSG name
Verified redeployment works with the Defender Plans config:
image

Thank you @jayhaddad for the contribution!

1 similar comment
@jamasten
Copy link
Contributor

jamasten commented Jul 5, 2024

Verified the NSG rules with: https://learn.microsoft.com/en-us/azure/bastion/bastion-nsg#apply
image
Successfully deployed the branch:
image
Successfully connected to the remote access VM using bastion
Verified the NSG name
Verified redeployment works with the Defender Plans config:
image

Thank you @jayhaddad for the contribution!

@jamasten jamasten merged commit a19ee08 into main Jul 5, 2024
3 checks passed
@jamasten jamasten deleted the bastionnsg branch July 5, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MLZ: Fix DeployDefenderPlans when using portal redeploy option MLZ: add NSG for Bastion subnet
2 participants