Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not default random tags in a reusable module #135

Open
1 task done
KevinBrooke opened this issue Jul 26, 2023 · 1 comment
Open
1 task done

Do not default random tags in a reusable module #135

KevinBrooke opened this issue Jul 26, 2023 · 1 comment

Comments

@KevinBrooke
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Description

Companies use systems to verify resources have tags assigned and this module passes the test as it is setting a default tag. This should be defaulted to {} to ensure users of the module are declaring their own tags.

variable "tags" {
type = map(string)
default = {
ENV = "test"
}
description = "The tags to associate with your network and subnets."
}

New or Affected Resource(s)/Data Source(s)

azurerm_virtual_network

Potential Terraform Configuration

variable "tags" {
  type = map(string)
  default = {}
  description = "The tags to associate with your network and subnets."
}

References

No response

@lonegunmanb
Copy link
Member

Thanks @KevinBrooke, I agree with you. But removing the default value would be considered as breaking change, so we would fix this issue in our next major version upgrade.

I'll let you know when we have progress, again, thanks for your suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants