Skip to content

Commit

Permalink
made some changes to clean up deployment
Browse files Browse the repository at this point in the history
  • Loading branch information
cshea-msft committed Aug 28, 2023
1 parent 85c7f84 commit 1cadacf
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 26 deletions.
6 changes: 1 addition & 5 deletions quickstart/101-azfw-with-fwpolicy/provider.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,5 @@ terraform {
}

provider "azurerm" {
features {
resource_group {
prevent_deletion_if_contains_resources = false // Set to True for Production
}
}
features {}
}
8 changes: 4 additions & 4 deletions quickstart/101-azfw-with-fwpolicy/variables.tf
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
// Create Variables for Location and Tags
variable "resource_group_location" {
type = string
type = string
description = "Location for all resources."
default = "eastus"
default = "eastus"
}

// Create Firewall Variables
variable "firewall_sku_tier" {
type = string
type = string
description = "Firewall SKU."
default = "Premium" # Valid values are Standard and Premium
default = "Premium" # Valid values are Standard and Premium
}

16 changes: 8 additions & 8 deletions quickstart/201-azfw-with-secure-hub/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ resource "azurerm_virtual_hub_connection" "azfw_vwan_hub_connection" {
associated_route_table_id = azurerm_virtual_hub_route_table.vhub_rt.id
propagated_route_table {
route_table_ids = [azurerm_virtual_hub_route_table.vhub_rt.id]
labels = ["VNet"]
labels = ["VNet"]
}
}
}
Expand Down Expand Up @@ -226,7 +226,7 @@ resource "azurerm_windows_virtual_machine" "vm_jump" {
name = "jump-vm"
resource_group_name = azurerm_resource_group.rg.name
location = azurerm_resource_group.rg.location
size = var.virtual_network_name
size = var.virtual_machine_size
admin_username = var.admin_username
admin_password = random_password.password.result
network_interface_ids = [azurerm_network_interface.vm_jump_nic.id]
Expand Down Expand Up @@ -284,10 +284,10 @@ resource "azurerm_virtual_hub_route_table" "vhub_rt" {
}

resource "random_password" "password" {
length = 20
min_lower = 1
min_upper = 1
min_numeric = 1
min_special = 1
special = true
length = 20
min_lower = 1
min_upper = 1
min_numeric = 1
min_special = 1
special = true
}
6 changes: 3 additions & 3 deletions quickstart/201-azfw-with-secure-hub/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@ output "resource_group_name" {
}

output "virtual_hub_name" {
value = azurerm_secure_hub.secure_hub.name
value = azurerm_virtual_hub.azfw_vwan_hub.name
}

output "jump_admin_password" {
sensitive = true
value = azurerm_secure_hub.vm_jump.admin_password
value = azurerm_windows_virtual_machine.vm_jump.admin_password
}

output "workload_admin_password" {
sensitive = true
value = azurerm_secure_hub.vm_workload.admin_password
value = azurerm_windows_virtual_machine.vm_workload.admin_password
}

12 changes: 6 additions & 6 deletions quickstart/201-azfw-with-secure-hub/variables.tf
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
// Create Variables for Location and Tags
variable "resource_group_location" {
type = string
type = string
description = "Location for all resources."
default = "eastus"
default = "eastus"
}
// Create Firewall Variables
variable "firewall_sku_name" {
type = string
type = string
description = "SKU name for the firewall."
default = "Premium" # Valid values are Standard and Premium
default = "Premium" # Valid values are Standard and Premium
}

// Create Virtual Machine Sku Size Variables
variable "virtual_machine_size" {
type = string
type = string
description = "Size of the virtual machine."
default = "Standard_D2_v3"
default = "Standard_D2_v3"
}

// Create Admin Username and Password
Expand Down

0 comments on commit 1cadacf

Please sign in to comment.