User Story 89659 #224
Merged
User Story 89659 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stemaMSFT
requested changes
May 16, 2023
|
@stemaMSFT @lonegunmanb I've made the requested edits and ready for another review. Thanks! |
lonegunmanb
requested changes
May 18, 2023
There was a problem hiding this comment.
Hi @TomArcherMsft thanks for opening this pr! A few comments.
|
CC: @stemaMSFT @lonegunmanb Thanks for the great review. I believe I've addressed the issues you mention. Please verify that I made the edits correctly. Thanks! |
lonegunmanb
reviewed
May 22, 2023
| resource_group_name = azurerm_resource_group.rg.name | ||
| storage_account_type = "Standard_LRS" | ||
| create_option = "Empty" | ||
| disk_size_gb = "1023" |
There was a problem hiding this comment.
Why the size is not 1024 but 1023?
There was a problem hiding this comment.
Thanks @TomArcherMsft, LGTM, only one question remains but the pr is good to merge.
Thanks, @lonegunmanb. I made the change.
lonegunmanb
approved these changes
May 22, 2023
There was a problem hiding this comment.
Thanks @TomArcherMsft, LGTM, only one question remains but the pr is good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Story 89659