Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Story 95456 #227

Merged
merged 5 commits into from
Jun 1, 2023
Merged

User Story 95456 #227

merged 5 commits into from
Jun 1, 2023

Conversation

TomArcherMsft
Copy link
Collaborator

@TomArcherMsft
Copy link
Collaborator Author

@grayzu @lonegunmanb @stemaMSFT The azure-vote.yaml file is used in the article to deploy an application.

@TomArcherMsft TomArcherMsft temporarily deployed to acctests May 27, 2023 01:49 — with GitHub Actions Inactive
lonegunmanb
lonegunmanb approved these changes May 27, 2023
View reviewed changes
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomArcherMsft, LGTM!

@TomArcherMsft TomArcherMsft temporarily deployed to acctests May 28, 2023 00:16 — with GitHub Actions Inactive
lonegunmanb
lonegunmanb approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomArcherMsft, LGTM!

grayzu
grayzu requested changes May 31, 2023
View reviewed changes
Copy link
Contributor

@grayzu grayzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Looks mostly good. One minor change.

quickstart/201-k8s-cluster-with-tf-and-aks/variables.tf Show resolved Hide resolved
@stemaMSFT
Copy link
Member

@grayzu I think after Tom's change we're just waiting on the E2E test. Can you kick it off?

@TomArcherMsft TomArcherMsft temporarily deployed to acctests June 1, 2023 01:27 — with GitHub Actions Inactive
lonegunmanb
lonegunmanb approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stemaMSFT
Copy link
Member

Are we good to merge this PR?

@TomArcherMsft
Copy link
Collaborator Author

@stemaMSFT The pattern with Mark/Zijie has been that once they both have verified the code, Zijie responds with LGTM (or similar) and Mark merges. Therefore, since Zijie has given his "LGTM" comment, I would think you're okay to merge.

@stemaMSFT stemaMSFT merged commit 69ef945 into Azure:master Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grayzu grayzu grayzu requested changes

@lonegunmanb lonegunmanb lonegunmanb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomArcherMsft @stemaMSFT @lonegunmanb @grayzu