Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 101-front-door-standard-premium to use azurerm 3.67.0 #242

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Update 101-front-door-standard-premium to use azurerm 3.67.0 #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c60dcf9
Update 101-front-door-standard-premium to use azurerm 3.67.0
johndowns Aug 7, 2023
c38c89a
Update provider version
johndowns Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion quickstart/101-front-door-premium-storage-blobs-private-link/providers.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = "~> 3.27.0"
version = "~> 3.0"
}

azapi = {
Expand Down
8 changes: 4 additions & 4 deletions quickstart/101-front-door-standard-premium/app-service.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,19 @@ resource "azurerm_windows_web_app" "app" {
site_config {
ftps_state = "Disabled"
minimum_tls_version = "1.2"
ip_restriction = [{
ip_restriction {
service_tag = "AzureFrontDoor.Backend"
ip_address = null
virtual_network_subnet_id = null
action = "Allow"
priority = 100
headers = [{
headers {
x_azure_fdid = [azurerm_cdn_frontdoor_profile.my_front_door.resource_guid]
x_fd_health_probe = []
x_forwarded_for = []
x_forwarded_host = []
}]
}
name = "Allow traffic from Front Door"
}]
}
}
}
2 changes: 1 addition & 1 deletion quickstart/101-front-door-standard-premium/providers.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = "~> 3.27.0"
version = "~> 3.67.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johndowns Why are you restricting the provider version to 3.67.x instead of using "~>3.0", which uses 3.x ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally I think we followed along with the other samples, which seem to use this approach (or did at the time, anyway).

I'd be happy to change this to ~> 3.0 if that's the standard - however, given there's been a breaking change somewhere between 3.27 and 3.67 (and hence the changes to app-service.tf in this PR), I assumed it's best to specify a version to avoid breaking changes affecting the sample.

Please let me know what you'd like me to do and I'll adjust as required.

}

random = {
Expand Down