User Story 145880 #243
Merged
User Story 145880 #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johndowns
approved these changes
Aug 10, 2023
| | `app_service_plan_sku_tier_name` | The name of the tier that the App Service plan SKU is in. | `Standard` | | ||
| | `resource_group_name_prefix` | Prefix of the resource group name that's combined with a random ID so name is unique in your Azure subscription. | rg | | ||
| | `resource_group_location` | Location of the resource group. | eastus | | ||
| | `app_service_plan_sku_name` | The SKU for the plan. Possible values include: B1, B2, B3, D1, F1, I1, I2, I3, I1v2, I2v2, I3v2, I4v2, I5v2, I6v2, P1v2, P2v2, P3v2, P0v3, P1v3, P2v3, P3v3, P1mv3, P2mv3, P3mv3, P4mv3, P5mv3, S1, S2, S3, SHARED, EP1, EP2, EP3, WS1, WS2, WS3, Y1. | S1 | |
There was a problem hiding this comment.
Out of curiosity, did you speak internally about whether it's a good idea to document the full list? App Service adds new SKUs semi-regularly so this list could go stale.
There was a problem hiding this comment.
@johndowns We did have that dialogue and it was decided that the benefits of having the information in the code (variables.tf and readme.md) outweigh the maintenance costs.
lonegunmanb
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Story 145880