added TF code for Azure Automation runbook #255
Conversation
There was a problem hiding this comment.
Great PR, @ericd-mst-github ! Only a few issues to make the sample consistent with the current best practices.
| | `runbook_type` | Type of the runbook. | PowerShell | | ||
| | `runbook_uri` | URI for the runbook content. | https://raw.githubusercontent.com/azureautomation/runbooks/master/Utility/ASM/Set-AzureScheduleWithRunbook.ps1 | | ||
| | `one_time_schedule_start_time` | Start time for the one-time runbook schedule. | "2023-09-23T00:00:00Z" | | ||
| | `hourly_schedule_start_time` | Start time for the hourly runbook schedule. | "2023-09-23T01:00:00Z" | |
There was a problem hiding this comment.
Needs an "Example" section (https://github.com/Azure/terraform/blob/master/quickstart/101-front-door-standard-premium/readme.md)
There was a problem hiding this comment.
Thanks again for checking. For the example section, we don't necessarily have a written topic published yet, as that will be a new VM tutorial that covers Auto-shutdown methods (PS, CLI, TF).
Should we have a separate Terraform tutorial doc auto generated through your current method, and I can link to that generated article from the new topic?
There was a problem hiding this comment.
TL/DR: Please leave the section out and it can be added after the article is published.
This is a chicken & egg situation where I can't publish the new article until the sample is published. Therefore, I don't know the exact URL until I write the article. When I'm coding the sample, I generally know what the article name is going to be so I "cheat" by putting in the URL for what will eventually be the published URL. The README includes the invalid URL for only a few hours or a day at most. However, in this case, you don't know the URL. Therefore, please leave the section out and it can be added after the article is published.
There was a problem hiding this comment.
Sounds good @TomArcherMsft and this makes sense to me.
I'll see about leaving the TF section out and go with the CLI/PS methods for now in the VM article. Let me know if further changes are needed for the current TF sample.
ericd-mst-github
temporarily deployed
to
acctests
GitHub Actions
Inactive
|
LGTM! |
|
#sign-off |
opening PR for automation runbook TF code.