Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure AI Studio E2E Secure #333

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

marvinbuss
Copy link

This PR adds the following:

  • E2E secure by default example for Azure AI Studio Hub and Project
  • Secure-by-default configurations for dependencies: Azure Key Vault, Azure Storage, Azure Application Insights, Azure Log Analytics, Azure Container Registry
  • Sample how to manage user-defined outbound rules at scale using a central module

Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marvinbuss thanks for opening this pr to us, we've the following error when we ran the e2e test, would you please modify your example so the users could try it with terraform apply without any further configuration requirement? Thanks!

Test_Quickstarts/quickstart/301-ai-studio-secure-e2e 2024-09-20T01:29:17Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; ╷
│ Error: No value for required variable
│ 
│   on variables.tf line 2:
│    2: variable "location" {
│ 
│ The root module input variable "location" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on variables.tf line 28:
│   28: variable "prefix" {
│ 
│ The root module input variable "prefix" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵
╷
│ Error: No value for required variable
│ 
│   on variables.tf line 39:
│   39: variable "subnet_id" {
│ 
│ The root module input variable "subnet_id" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
╵}
    apply.go:34: 
        	Error Trace:	/home/runtimeuser/go/pkg/mod/github.com/gruntwork-io/terratest@v0.47.1/modules/terraform/apply.go:34
        	            				/home/runtimeuser/go/pkg/mod/github.com/!azure/terraform-module-test-helper@v0.26.0/e2etest.go:107
        	            				/home/runtimeuser/go/pkg/mod/github.com/!azure/terraform-module-test-helper@v0.26.0/e2etest.go:87
        	            				/home/runtimeuser/go/pkg/mod/github.com/!azure/terraform-module-test-helper@v0.26.0/e2etest.go:55
        	            				/src/test/e2e/quickstart_test.go:50
        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1; ╷
        	            	│ Error: No value for required variable
        	            	│ 
        	            	│   on variables.tf line 2:
        	            	│    2: variable "location" {
        	            	│ 
        	            	│ The root module input variable "location" is not set, and has no default
        	            	│ value. Use a -var or -var-file command line argument to provide a value for
        	            	│ this variable.
        	            	╵
        	            	╷
        	            	│ Error: No value for required variable
        	            	│ 
        	            	│   on variables.tf line 28:
        	            	│   28: variable "prefix" {
        	            	│ 
        	            	│ The root module input variable "prefix" is not set, and has no default
        	            	│ value. Use a -var or -var-file command line argument to provide a value for
        	            	│ this variable.
        	            	╵
        	            	╷
        	            	│ Error: No value for required variable
        	            	│ 
        	            	│   on variables.tf line 39:
        	            	│   39: variable "subnet_id" {
        	            	│ 
        	            	│ The root module input variable "subnet_id" is not set, and has no default
        	            	│ value. Use a -var or -var-file command line argument to provide a value for
        	            	│ this variable.
        	            	╵}
        	Test:       	Test_Quickstarts/quickstart/301-ai-studio-secure-e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants