Resolve ghc 9.2 warnings #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves most but not all warnings. See GitHub issue 469.
In version 2.3 of the mtl library, re-export of other modules was removed; so now those other modules need to be imported, if functions from them are needed. To avoid duplicate import when compiling with earlier mtl/GHC versions, the import statements need to explicitly list the functions imported from each module.
This abstraction was added to support building with GHC 7.10 (which uses Control.Monad.Except) and older versions (which still used Control.Monad.Error), without having to introduce CPP directives everywhere. Since we no longer support those earlier GHC versions, there is no need for this API.
quark17
force-pushed
the
resolve-ghc-9.2-warnings
branch
from
8483ba8
to
c73048a
Compare
|
I have added two more commits. One gets BSC to compile with GHC 9.6, by addressing changes in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves most of the incomplete-pattern warnings that occurred when building with GHC 9.2.8 (Issue #469). This also adds examples for SV-preprocessor issues that were revealed by the warnings (Issue #584). That seems to be the only area where the warnings were an indication of an issue.