comp: remove most imports of Data.Generics
#722
Conversation
99% of the uses of the `Data.Generics` import from `syb` was to qualify the names `Data` and `Typeable`, but these have long since been available directly in `base` along with `DeriveDataTypeable` for many years now. The `syb` exports are in fact just re-exports from base. Migrate most of the code to just use `Data.Data` directly instead. At the same time, this touches up some of the import lists to be a little more consistent, but is otherwise functionally identical. Signed-off-by: Austin Seipp <aseipp@pobox.com>
|
|
||
| ordC :: IConInfo a -> Int | ||
| -- XXX This definition would be nice, but it imposes a (Data a) context |
There was a problem hiding this comment.
Are you removing this comment, because it's no longer meaningful? If it's still meaningful, I'd leave it in. (I don't offhand understand what it's saying.)
|
|
||
| import qualified Data.Generics as Generic | ||
| import Data.Graph | ||
| import Control.Monad.State(State, evalState, liftIO, get, put) |
There was a problem hiding this comment.
You reorder a few import lists, and I don't quite understand your choices, but OK.
| @@ -55,10 +55,10 @@ module CType( | |||
| import Prelude hiding ((<>)) | |||
| #endif | |||
|
|
|||
| import Data.Data (Data, Typeable) | |||
There was a problem hiding this comment.
Did you intend a space here?
|
|
||
| -- ============================== | ||
| -- IConInfo | ||
|
|
||
| -- FIXME: syb includes an orphan to work around the fact Handle needs a Data |
There was a problem hiding this comment.
And the only place we have Handle in a data structure needing Data is here in IConInfo (ICHandle), so you've chosen to put the instance here? Ok.
|
99% of the uses of the
Data.Genericsimport fromsybwas to qualify the namesDataandTypeable, but these have long since been available directly inbasealong withDeriveDataTypeablefor many years now. Thesybexports are in fact just re-exports from base. Migrate most of the code to just useData.Datadirectly instead.At the same time, this touches up some of the import lists to be a little more consistent but is otherwise functionally identical.