-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support splitting up struct method parameters into multiple input ports #729
base: main
Are you sure you want to change the base?
Changes from all commits
49532f4
363cc7b
b24ca9c
92fa2e8
c6b22fa
57258ec
8fdb09d
5945a7c
25695a4
6568cc8
1b1f033
730f044
7975da7
3ba06d4
96c35e5
d08c97a
b651d36
4020ade
2c9e86e
0c15378
1ecce93
936d140
eccaf03
4e48c17
14fb02c
7aea56f
af1e1eb
a52f2e6
36a4dc2
8999a65
be3d910
150d29c
c8114b1
0ea992e
9d7921f
f0d8ac7
7067fbe
0e23ad0
1329534
6f8c504
b1165c9
0868d79
df0f863
d7b1859
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -88,15 +88,17 @@ interface VRWireN#(numeric type n); | |
endinterface | ||
|
||
// for addCFWire desugaring | ||
// This uses prim types like something coming from genwrap. | ||
module vMkRWire1(VRWireN#(1)); | ||
|
||
(* hide *) | ||
VRWire#(Bit#(1)) _rw <- vMkRWire; | ||
method wset(v); | ||
return(toPrimAction(_rw.wset(v))); | ||
endmethod | ||
method wget = _rw.wget; | ||
method whas = pack(_rw.whas); | ||
function rw_wset(v); | ||
return toPrimAction(_rw.wset(v)); | ||
endfunction | ||
method wset = primMethod(Cons("v", Nil), rw_wset); | ||
method wget = primMethod(Nil, _rw.wget); | ||
method whas = primMethod(Nil, pack(_rw.whas)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the user writes a This occurs in BSC after scheduling, when the module is in The interface for The reason that you needed to add I think it might be better to write However, all of this does make me wonder: For imported modules in BH code, we have written them as an import of the raw interface and then a wrapper module (that converts from the raw interface and inserts calls to primitives to save types etc) -- for example, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, it looks like someone added a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To be honest I haven't dug into I did try changing the I suppose it is possible to use |
||
|
||
endmodule | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that
primMethod
here is only exported so that it can be used inPreludeBSV
forvMkRWire1
and can be removed when that's resolved.