Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/move request property to negotiation #459

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

svituz
Copy link
Contributor

@svituz svituz commented Sep 25, 2024

Negotiator pull request:

Description:

This PR removes the request property and adds humanReadable and resources to the Negotiation entity.
When a negotiation is created, the two properties are added from the request and the request is removed

Checklist:

Make sure you tick all the boxes below if they are true or do not apply before you ask for review

  • I have performed a self-review of my code
  • I have made my code as simple as possible
  • I have added relevant tests for my changes and the code coverage has not dropped substantially
  • I have removed all commented code
  • I have updated the documentation in all relevant places (Javadoc, Swagger, MDs...)
  • I have described the PR and added a meaningful title in the Conventional Commits format

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.85%. Comparing base (a6e76a2) to head (72996b1).

Files with missing lines Patch % Lines
...or/negotiation/mappers/NegotiationModelMapper.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #459      +/-   ##
============================================
- Coverage     84.22%   83.85%   -0.37%     
+ Complexity      955      932      -23     
============================================
  Files           140      140              
  Lines          3885     3822      -63     
  Branches        245      239       -6     
============================================
- Hits           3272     3205      -67     
- Misses          432      437       +5     
+ Partials        181      180       -1     
Flag Coverage Δ
unit 83.85% <92.59%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svituz svituz force-pushed the refactor/move_request_property_to_negotiation branch from 9175cfc to 2aec216 Compare September 25, 2024 10:19
@jungwire jungwire self-requested a review September 25, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants