Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move request property to negotiation #459

Merged
merged 29 commits into from
Sep 27, 2024

refactor: wip removing currentStatePerResource

7c57191
Select commit
Loading
Failed to load commit list.
Merged

refactor: move request property to negotiation #459

refactor: wip removing currentStatePerResource
7c57191
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 25, 2024 in 0s

24.48% (-59.74%) compared to a6e76a2

View this Pull Request on Codecov

24.48% (-59.74%) compared to a6e76a2

Details

Codecov Report

Attention: Patch coverage is 70.83333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 24.48%. Comparing base (a6e76a2) to head (7c57191).

Files with missing lines Patch % Lines
...iator/governance/resource/ResourceServiceImpl.java 0.00% 5 Missing ⚠️
...gotiator/negotiation/NegotiationSpecification.java 0.00% 2 Missing ⚠️
...or/negotiation/mappers/NegotiationModelMapper.java 0.00% 2 Missing ⚠️
...otiator/negotiation/request/QueryV2Controller.java 0.00% 2 Missing ⚠️
...bbmri_eric/negotiator/negotiation/Negotiation.java 93.33% 1 Missing ⚠️
...egotiator/negotiation/NegotiationResourceLink.java 83.33% 1 Missing ⚠️
...negotiator/negotiation/NegotiationServiceImpl.java 93.75% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a6e76a2) and HEAD (7c57191). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (a6e76a2) HEAD (7c57191)
unit 6 1
Additional details and impacted files 
@@              Coverage Diff              @@
##             master     #459       +/-   ##
=============================================
- Coverage     84.22%   24.48%   -59.74%     
+ Complexity      955      258      -697     
=============================================
  Files           140      141        +1     
  Lines          3885     3843       -42     
  Branches        245      240        -5     
=============================================
- Hits           3272      941     -2331     
- Misses          432     2850     +2418     
+ Partials        181       52      -129

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov