Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SETTING] 설정 페이지 추가 및 수정 #106

Merged
merged 32 commits into from
Oct 23, 2023
Merged

[SETTING] 설정 페이지 추가 및 수정 #106

merged 32 commits into from
Oct 23, 2023

Conversation

LUNA-KK
Copy link
Contributor

@LUNA-KK LUNA-KK commented Sep 24, 2023 •
edited
Loading

[#100] request

PC 설정 페이지를 추가하고 모바일 설정 페이지를 수정했습니다.
기존 모바일 페이지가 거의 완성되어 있는 상태라 유지하고 라우팅을 추가했습니다.

회원 탈퇴, 비밀번호 변경 기능을 추가했습니다.
SNS 사용자의 경우 비밀번호 변경 및 회원 탈퇴가 불가능합니다.

앱 버전을 확인하는 api가 없어서 우선 모달창만 구현했습니다.

Please check if the PR fulfills these requirements

  • It's submitted to develop branch, not the main branch
  • The commit message follows our guidelines
  • There are no warning message when you run yarn lint
  • Docs updated for breaking changes

Screenshot

image
image

@LUNA-KK LUNA-KK self-assigned this Sep 25, 2023
@LUNA-KK LUNA-KK added the enhancement New feature or request label Sep 25, 2023
hyejun0228

This comment was marked as resolved.

Sign in to view

hanagertrudeKim
hanagertrudeKim requested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@hanagertrudeKim hanagertrudeKim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!
우연히 들렀지만, 간단히 코멘트 할 점이 보여서 적어두었으니 확인해주세요!

+yarn.lock 파일은 왜 수정이 되었는지 알수있을까요?

src/pages/Follow/components/SearchPage.tsx Outdated Show resolved Hide resolved
src/pages/Setting/PC/ManageAccount.tsx Show resolved Hide resolved
src/pages/Setting/PC/ManageAccount.tsx Outdated Show resolved Hide resolved
src/pages/Setting/PC/Service.tsx Outdated Show resolved Hide resolved
src/pages/Setting/PC/hook/useModifyPassword.ts Outdated Show resolved Hide resolved
src/pages/Setting/PC/hook/useModifyPassword.ts Outdated Show resolved Hide resolved
src/pages/Setting/PC/hook/useModifyPassword.ts Outdated Show resolved Hide resolved
src/pages/Setting/PC/hook/useTripleBlindCheck.ts Outdated Show resolved Hide resolved
src/pages/Setting/PC/index.tsx Show resolved Hide resolved
hyejun0228
hyejun0228 requested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@hyejun0228 hyejun0228 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
우선 pr제목을 다른 pr들 형식에 맞춰 수정해주세요.
수정이 필요해 보이거나 궁금한 사항 몇개 적어두었습니다.

+/Setting/PC 에서의 추가적인 폴더링이 필요할것 같은데 어떻게 생각하시나요?

+전체적으로 버튼에 cursor: pointer 추가 부탁드립니다!

src/pages/Setting/PC/Service.tsx Outdated Show resolved Hide resolved
src/pages/Setting/PC/Service.module.scss Outdated Show resolved Hide resolved
src/pages/Setting/PC/hook/useModifyPassword.ts Outdated Show resolved Hide resolved
src/pages/Setting/UserSetting/index.tsx Outdated Show resolved Hide resolved
src/pages/Setting/UserSetting/index.tsx Outdated Show resolved Hide resolved
@LUNA-KK LUNA-KK changed the title Feature/#100 설정 페이지 추가 및 수정 [Setting] 설정 페이지 추가 및 수정 Sep 25, 2023
@LUNA-KK LUNA-KK changed the title [Setting] 설정 페이지 추가 및 수정 [SETTING] 설정 페이지 추가 및 수정 Sep 25, 2023
@kimeodml kimeodml removed the request for review from 20HyeonsuLee September 26, 2023 12:03
@LUNA-KK
Copy link
Contributor Author

LUNA-KK commented Oct 6, 2023

다른 branch를 merge 받고 필요한 라이브러리가 있어서 설치했습니다.
@hanagertrudeKim

@LUNA-KK
Copy link
Contributor Author

LUNA-KK commented Oct 6, 2023 •
edited
Loading

PC, Mobile, hook, static 폴더로 나누어보았습니다.
더 세밀하게 파일을 분류할 필요가 있을까요?
+pointer 추가했습니다!
@hyejun0228

ChoiWonBeen
ChoiWonBeen reviewed Oct 10, 2023
View reviewed changes
src/api/user/entity.ts Outdated Show resolved Hide resolved
ChoiWonBeen
ChoiWonBeen reviewed Oct 10, 2023
View reviewed changes
src/store/auth.ts Outdated Show resolved Hide resolved
@LUNA-KK LUNA-KK merged commit e3f2830 into develop Oct 23, 2023
1 check passed
@LUNA-KK LUNA-KK deleted the feature/#100 branch October 23, 2023 09:29
ChoiWonBeen added a commit that referenced this pull request Jan 18, 2024
@ChoiWonBeen
Merge pull request #211 from BCSDLab/feature/#106
d82c205 
fix: 문의하기 글쓰기 실패 해결
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanagertrudeKim hanagertrudeKim hanagertrudeKim approved these changes

@hyejun0228 hyejun0228 hyejun0228 approved these changes

@chaeseungyun chaeseungyun Awaiting requested review from chaeseungyun chaeseungyun is a code owner

@KimKyungYun KimKyungYun Awaiting requested review from KimKyungYun

@kimeodml kimeodml Awaiting requested review from kimeodml kimeodml is a code owner

@junghaesung79 junghaesung79 Awaiting requested review from junghaesung79 junghaesung79 is a code owner

@HAEROOL HAEROOL Awaiting requested review from HAEROOL HAEROOL is a code owner

@ChoiWonBeen ChoiWonBeen Awaiting requested review from ChoiWonBeen

Assignees

@LUNA-KK LUNA-KK

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LUNA-KK @ChoiWonBeen @hanagertrudeKim @hyejun0228