-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Map] 메인 페이지 지도 구현 #107
Merged
Merged
[Map] 메인 페이지 지도 구현 #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimeodml
requested review from
chaeseungyun,
hyejun0228,
KimKyungYun,
LUNA-KK,
junghaesung79,
20HyeonsuLee and
HAEROOL
as code owners
October 9, 2023 13:37
chaeseungyun
requested changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
제 환경에서 에러가 하나 있는데 확인 부탁드리겠습니다
ChoiWonBeen
reviewed
Oct 10, 2023
ChoiWonBeen
reviewed
Oct 10, 2023
ChoiWonBeen
reviewed
Oct 10, 2023
ChoiWonBeen
reviewed
Oct 10, 2023
ChoiWonBeen
reviewed
Oct 10, 2023
ChoiWonBeen
reviewed
Oct 10, 2023
src/pages/Home/components/Map/components/MarkerHtml/MarkerHtml.module.scss
Outdated
Show resolved
Hide resolved
ChoiWonBeen
reviewed
Oct 10, 2023
ChoiWonBeen
reviewed
Oct 10, 2023
ChoiWonBeen
reviewed
Oct 10, 2023
ChoiWonBeen
reviewed
Oct 10, 2023
src/pages/Home/components/Map/components/MobileOptions/index.tsx
Outdated
Show resolved
Hide resolved
hyejun0228
requested changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다! 궁금한점 리뷰 달아놨습니다.
- 모바일 버전에서 오른쪽 밑에 있는 네이버 마크가 figma에는 없어서 수정해야할 것 같습니다.
This reverts commit 4e1f488.
로고 제거 하는 옵션이 있었는데 현재는 그 기능을 빼 버렸더라고요. 그래서 네이버 마크는 유지해야합니다! |
hyejun0228
approved these changes
Oct 20, 2023
chaeseungyun
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#102] request
Please check if the PR fulfills these requirements
develop
branch, not themain
branchyarn lint
Screenshot