-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[공통] React Query v3 -> v5 로 버전 업 #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
참고해서 코인사장님에도 적용해보겠습니다...
Co-authored-by: MinGu Jeong <51395707+MinGu-Jeong@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니다! 작성해주신 코드 활용해서 제 코드에도 적용하겠습니다😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
변경하느라 고생하셨습니다
주신 예제 참고해서 앞으로 코드 작성할 때 활용해볼게요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
serach.exclude 로 검색 필터링 되다는 걸 처음 알았네요. 고생하셨습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tanstack query v5라니! 감격... 너무 좋아요~! data?.data 너무 불편했는데 하나 큰걸 해결해주시고 가는군요! 감사합니다~!
"**/package-lock.json": true, | ||
"**/yarn.lock": true, | ||
}, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
갓 원빈의 EOL..
#118 request
React Query 버전을 올립니다.
useSuspenseQuery
라는 훅을 사용할 수 있는데,data?.data
이런 불필요한 구조들을 전부 없앨 수 있어요T | undefined
로 추론되던 값이,<T>
로만 추론되기에, 사용이 편하고, Suspense를 적용하는것도 예제를 드려봤어요.사용중인 모든 쿼리를 5버전에 맞춰 conflict나 버그가 많이 일어날 수 있으니, 제작한 페이지 꼭 한번씩 확인 부탁드려요.
머지되면 설치도 한번씩 해야할거구요
추가적으로, 검색할 때 방해되는 yarn.lock, node_modules등을 무시할 수 있도록 세팅을 추가했어요
Please check if the PR fulfills these requirements
develop
branch, not themain
branchyarn lint
Screenshot