Feature/#76 메인페이지 마커 디자인변경, 드롭다운메뉴 제작 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimKyungYun
requested review from
ChoiWonBeen,
jaewoogwak,
chaeseungyun and
hyejun0228
as code owners
ChoiWonBeen
requested changes
Jul 4, 2023
src/pages/Home/components/Map/components/MobileOptions/MobileOptions.module.scss
Outdated
Show resolved
Hide resolved
chaeseungyun
requested changes
Jul 4, 2023
ChoiWonBeen
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#76] request
1차베포버전 메인페이지 디자인 수정했습니다.
마커 디자인변경하고, 마커필터 드롭다운메뉴로 구성변경했습니다.
마커에 인덱스 번호를 추가하는 과정에서 useEffect와의 충돌로 인덱싱에 문제가 생겨서 마커의 z-index 속성을 이용해서 getZIndex를 사용했습니다.
따로 마커의 인덱스 번호를 방법이 있다면 해당 방법으로 수정하도록 하겠습니다.
Please check if the PR fulfills these requirements
developbranch, not themainbranchyarn lintScreenshot