Feature/#71 글쓰기 페이지 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyejun0228
requested review from
ChoiWonBeen,
jaewoogwak,
chaeseungyun and
KimKyungYun
as code owners
ChoiWonBeen
requested changes
Jul 12, 2023
Comment on lines
+13
to
17
| const [opened, active, inActive] = useBooleanState(false); | ||
| useEffect(() => { | ||
| if (imageList === null || imageList.length === 0) inActive(); | ||
| else active(); | ||
| }, [imageList, active, inActive]); |
There was a problem hiding this comment.
얘내들을 모아서 로직을 분리한다면, useWisiwygImageOpen 같은 훅으로 모아서 useEffect를 넣어두는 쪽으로 작성한다면 컴포넌트에 로직이 뭉치는 것을 방지할 수 있을 것 같아요
There was a problem hiding this comment.
const [opened, active, inActive] = useBooleanState(false); 에서 반환되는 값들이 useEffect 뿐만아니라 AddImage.tsx 에도 쓰이고 있어 컴포넌트를 나눠준다면 더 복잡해지지 않을까요..?!
ChoiWonBeen
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
#89 PR 한번 확인해주시고 해당 PR을 먼저 병합한 뒤, 최신 develop을 병합하고 수정할게 더 있을지 한번 확인해보세요. 전부 괜찮다면 그때 병합해도 괜찮을 것 같네요.
Feature/#81 PR 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#71] post
Please check if the PR fulfills these requirements
developbranch, not themainbranchyarn lint사진 선택의 세세한 기능과 별점에 따른 숫자 부분은 다음 pr로 올리도록하겠습니다.
Screenshot