Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#71 글쓰기 페이지 #81
Feature/#71 글쓰기 페이지 #81
Changes from 10 commits
6e4fe6b
0a91a74
364b02f
6fd389d
fc36b4a
fbbb68a
51001ca
3f94d62
0bc2dcc
57d292e
43c4f05
0bdeec2
3e58329
bcdd6b3
4331b69
b6545bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
얘내들을 모아서 로직을 분리한다면,
useWisiwygImageOpen
같은 훅으로 모아서 useEffect를 넣어두는 쪽으로 작성한다면 컴포넌트에 로직이 뭉치는 것을 방지할 수 있을 것 같아요There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const [opened, active, inActive] = useBooleanState(false);
에서 반환되는 값들이 useEffect 뿐만아니라AddImage.tsx
에도 쓰이고 있어 컴포넌트를 나눠준다면 더 복잡해지지 않을까요..?!