Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Post, Search] 리뷰 쓰기 기능 추가, 검색페이지 변경 대응 및 기능 연결 #91

Merged
merged 10 commits into from
Sep 4, 2023

Conversation

ChoiWonBeen
Copy link
Member

[#77, #23] request

기존 검색 페이지와 글쓰기까지의 기능을 연결하고, 리뷰 글쓰기 기능을 추가했습니다.

  • 검색 api 변경 대응
    • 검색 결과로 나온 상점의 정보를 가지고 리뷰 글쓰기 페이지로 이동
    • UI에 포함되지 않는 placeIdlocation.state로 넘겨 활용
    • 상점 사진을 실제 구글 데이터로 변경(1개)
  • 글쓰기 기능 추가
    • jotai를 활용해 별점, 위지윅 각각에 존재하는 상태를 저장
    • 이미지 정보를 보내기 위해 formData클래스를 활용해 사진의 수만큼 반복해서 append

Please check if the PR fulfills these requirements

  • It's submitted to develop branch, not the main branch
  • The commit message follows our guidelines
  • There are no warning message when you run yarn lint
  • Docs updated for breaking changes

Screenshot

image image image

Copy link
Contributor

@kimeodml kimeodml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

src/pages/SearchDetails/components/SearchItemPC.tsx Outdated Show resolved Hide resolved
src/pages/SearchDetails/index.tsx Outdated Show resolved Hide resolved
src/components/editor/Wysiwyg/index.tsx Show resolved Hide resolved
Copy link
Contributor

@kimeodml kimeodml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 상점 검색 쪽 디자인이랑 글쓰기 검색쪽이랑 디자인이 똑같아서 추상화가 필요해 보이는데 브랜치 주제와 많이 벗어나서 무리겠죠...?😢
image
image

@ChoiWonBeen
Copy link
Member Author

고생하셨습니다! 상점 검색 쪽 디자인이랑 글쓰기 검색쪽이랑 디자인이 똑같아서 추상화가 필요해 보이는데 브랜치 주제와 많이 벗어나서 무리겠죠...?😢

아예 그대로 가져가서 써도 될 것 같아요~
상점 검색 UI 만들때 가져다 쓰게끔 인지만 하면 될 것 같아요

Copy link
Contributor

@HAEROOL HAEROOL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 수고하셨습니다

@kimeodml kimeodml merged commit 92fc538 into develop Sep 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants