-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Map] 메인 페이지 지도 구현, 메인 페이지 지도 기능 추가 #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨어요~ 제가 확인한 문제는 딱히 없는거같구 고려해볼만한 점들만 한번 쭉 훑어봐주세요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~ #92 (comment) 에서 언급한 sprite svg 파일 분리만 마저 생각해보시면 좋을 것 같아요!
우선 파일명 변경해 놓았습니다. svg 파일들이 완전히 추가된 후에 폴더 기준으로 묶지 않을까 싶습니다.9df5b9e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다! 늦게 리뷰드려 죄송합니다ㅜㅜ
[#44, #85] request
지도 및 마커의 코드를 custom-hook으로 변경했습니다.
images/search/defaultImage
로 대체했습니다.Please check if the PR fulfills these requirements
develop
branch, not themain
branchyarn lint
Screenshot