Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Map] 메인 페이지 지도 구현, 메인 페이지 지도 기능 추가 #92

Merged
merged 47 commits into from
Sep 4, 2023

Conversation

kimeodml
Copy link
Contributor

@kimeodml kimeodml commented Aug 13, 2023

[#44, #85] request

지도 및 마커의 코드를 custom-hook으로 변경했습니다.

  • 옵션 버튼들의 경우 전역 상태로 관리합니다.
  • naver.maps.Marker에 photo 메소드가 없기 때문에 images/search/defaultImage로 대체했습니다.
  • 현재 위치에서 2km 이내의 데이터만 확인할 수 있기에 location의 값을 인위적으로 변경하여 확인 부탁드립니다.
[좌표]
{
  "lat": 37.4986493,
  "lng":  127.0345793
}

[계정] 
ID : map
PW : map1234!

Please check if the PR fulfills these requirements

  • It's submitted to develop branch, not the main branch
  • The commit message follows our guidelines
  • There are no warning message when you run yarn lint
  • Docs updated for breaking changes

Screenshot

image

Copy link
Member

@ChoiWonBeen ChoiWonBeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요~ 제가 확인한 문제는 딱히 없는거같구 고려해볼만한 점들만 한번 쭉 훑어봐주세요!

src/components/common/SideNavigation/index.tsx Outdated Show resolved Hide resolved
src/components/common/SideNavigation/index.tsx Outdated Show resolved Hide resolved
src/components/common/SideNavigation/index.tsx Outdated Show resolved Hide resolved
src/store/filter.ts Show resolved Hide resolved
src/utils/hooks/useGeolocation.ts Outdated Show resolved Hide resolved
src/api/shop/entity.ts Show resolved Hide resolved
@kimeodml kimeodml requested review from ChoiWonBeen and HAEROOL and removed request for jaewoogwak August 28, 2023 13:54
Copy link
Member

@ChoiWonBeen ChoiWonBeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ #92 (comment) 에서 언급한 sprite svg 파일 분리만 마저 생각해보시면 좋을 것 같아요!

@kimeodml
Copy link
Contributor Author

kimeodml commented Sep 2, 2023

우선 파일명 변경해 놓았습니다. svg 파일들이 완전히 추가된 후에 폴더 기준으로 묶지 않을까 싶습니다.9df5b9e

@kimeodml kimeodml merged commit 8d4a851 into develop Sep 4, 2023
1 check passed
Copy link
Contributor

@HAEROOL HAEROOL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 늦게 리뷰드려 죄송합니다ㅜㅜ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants