Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[USER] 마이페이지 구현 #93

Merged
merged 51 commits into from
Oct 16, 2023
Merged

[USER] 마이페이지 구현 #93

merged 51 commits into from
Oct 16, 2023

Conversation

HAEROOL
Copy link
Contributor

@HAEROOL HAEROOL commented Aug 17, 2023

[#84] request

마이페이지 구현했습니다.

  • 기존의 PC 뷰를 제외하고 모바일 뷰로 우선 통일하여 구현하였습니다. PC 뷰가 확정나면 추가 구현 예정입니다.
  • 보관함의 경우 보관한 데이터 자체에 현재 겹치는 부분이 있어 무한스크롤 동작 시 key prop이 겹칩니다. 해당 부분은 데이터가 달라진다면 사라질 예정입니다.

Please check if the PR fulfills these requirements

  • It's submitted to develop branch, not the main branch
  • The commit message follows our guidelines
  • There are no warning message when you run yarn lint
  • Docs updated for breaking changes

Screenshot

스크린샷 2023-08-17 오후 6 39 49
스크린샷 2023-08-17 오후 6 40 10

@HAEROOL
feat: PC 뷰, 모바일 뷰 네비게이션 추가
f10262f
@HAEROOL
Merge branch 'develop' into feature/#84
202d448
@HAEROOL
feat: 페이지 레이아웃 구성
8fee9a0
@HAEROOL
feat: 마이페이지 헤더 UI 구현
f0b0bfb
@HAEROOL
feat: 리뷰/북바크 선택 바 UI추가
853735b
@HAEROOL
refactor: 내가 쓴 글 변수명 변경
d3bfe82
@HAEROOL
feat: 내가 쓴 글 UI 구현
6c0395c
@HAEROOL
style: 모바일 내 리뷰 height 변경
7c64630
@HAEROOL
feat: 북마크 모바일 UI 구현
9170bd7
@HAEROOL
feat: 북마크, 리뷰 데이터 없을 경우 UI 추가
b861860
@HAEROOL
feat: 데스크톱 뷰 리뷰, 북마크 없을 경우 UI 구현
413bc12
@HAEROOL
feat: 프로필 데이터 api 연동
0c84cee
@HAEROOL
feat: 내가 쓴 리뷰 api 연동
3972d9a
@HAEROOL
feat: 펼치기 버튼 이벤트 label로 확장
78bbee0
@HAEROOL
feat: 북마크 api 연동
ce81746
@HAEROOL
feat: 리뷰 존재하지 않거나, 에러발생 시 컴포넌트 추가
e22e3a0
@HAEROOL
feat: 프로필 사진 변경 모달 UI 구현
0ab52af
@HAEROOL
sylte: 프로필 변경 모달 height 변경
17281f5
@HAEROOL
feat: 프로필 이미지 변경 api 연동
6133c28
@HAEROOL
refactor: 이미지 변경 함수 함수명 변경
a473640
@HAEROOL
feat: 닉네임 변경 api 연동
bcd823b
@HAEROOL
style: 웹뷰 UI 모바일 버전 UI로 통일
447f40f
@HAEROOL
refactor: 미사용 컴포넌트 삭제
19a2c3e
@HAEROOL
style: 보관함 상점 사진 height 증가
61a1159
@HAEROOL
style: 프로필 닉네임 width 삭제
8c5c661
@HAEROOL
feat: 보관함 무한스크롤 구현
57fea29
@HAEROOL
feat: 팔로워 수 api 연동
d0480eb
@HAEROOL
feat: 설정 버튼 연결
4e097e4
@HAEROOL
styles: toast 스타일 변경
a4f75b1
@HAEROOL
feat: toast 닉네임props 추가
299a9d9
ChoiWonBeen
ChoiWonBeen approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@ChoiWonBeen ChoiWonBeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로직에 문제없이 잘짜셨네요! 읽기도 수월했습니다 ㅎ
몇가지 오타나 생각해볼만한 점들만 좀 올려뒀으니 한번 확인해보시고 수정할 부분들은 수정해주시면 좋을 것 같아요 고생하셨습니다~

src/api/mypage/entity.ts Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/api/mypage/entity.ts Outdated Show resolved Hide resolved
src/api/mypage/entity.ts Outdated Show resolved Hide resolved
src/api/mypage/entity.ts Outdated Show resolved Hide resolved
src/pages/MyPage/components/HambergerBoard/index.tsx Outdated Show resolved Hide resolved
src/pages/MyPage/components/Information/index.tsx Outdated Show resolved Hide resolved
src/pages/MyPage/components/Information/Information.module.scss Outdated Show resolved Hide resolved
src/pages/MyPage/components/ProfileModal/index.tsx Show resolved Hide resolved
src/api/mypage/index.ts

export const getScraps = async (pageParam:number) => myPageApi.get<ScrapResponse>(`/scraps?cursor=${pageParam}`);

export const patchProfileImage = async (image:FormData | null) => myPageApi.patch<PatchProfileImageResponse>('/user/profile', image, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 이해가 되진 않지만 저는 테스트할때 해당 부분에서 2초가 넘어가서 에러가 나거든요..? myPageApi의 exceed시간을 늘리거나 해야할 것 같은데.. 사실 2초 넘어갈만한 작업은 아닌 것 같아서 백엔드측에 문의를 해볼게요

@kimeodml kimeodml requested review from haejinyun and kimeodml and removed request for jaewoogwak August 28, 2023 13:57
kimeodml
kimeodml reviewed Sep 16, 2023
View reviewed changes
Copy link
Contributor

@kimeodml kimeodml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 리뷰한 부분만 수정하면 될것 같아요!
브랜치 최신화 한 후에 수정부탁드립니다. 고생하셨어요!!

src/pages/MyPage/MyPage.module.scss Outdated Show resolved Hide resolved
src/pages/MyPage/MyPage.module.scss Outdated Show resolved Hide resolved
src/pages/MyPage/components/BookMark/index.tsx Outdated Show resolved Hide resolved
src/pages/MyPage/components/Information/Information.module.scss Show resolved Hide resolved
@kimeodml kimeodml merged commit 5308a73 into develop Oct 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimeodml kimeodml kimeodml left review comments

@ChoiWonBeen ChoiWonBeen ChoiWonBeen approved these changes

@chaeseungyun chaeseungyun Awaiting requested review from chaeseungyun chaeseungyun is a code owner

@hyejun0228 hyejun0228 Awaiting requested review from hyejun0228 hyejun0228 is a code owner

@KimKyungYun KimKyungYun Awaiting requested review from KimKyungYun

@haejinyun haejinyun Awaiting requested review from haejinyun

@LUNA-KK LUNA-KK Awaiting requested review from LUNA-KK LUNA-KK is a code owner

@junghaesung79 junghaesung79 Awaiting requested review from junghaesung79 junghaesung79 is a code owner

@20HyeonsuLee 20HyeonsuLee Awaiting requested review from 20HyeonsuLee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HAEROOL @ChoiWonBeen @kimeodml