Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DETAIL] 메인페이지 주소 변경 UI 구현 #95
[DETAIL] 메인페이지 주소 변경 UI 구현 #95
Changes from all commits
8194970
7823c68
a36daee
0e11dd9
5092e32
d5b9f0e
068d2ed
e19fea8
94f6a65
477f29e
64369f2
18ef8a4
7c2a99a
c849a5f
122a862
2266fc0
103b643
555be6d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네이버 로그인을 위한 개발용 프록시였는데, 바꿔야만 동작하나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네이버 클라우드 플렛폼에 있는 현재의 위치를 가져와 지도에 표시해주는 api를 사용해주기 위해서는 proxy 를 바꿔줄 필요가 있어 바꿔주게 됐습니다. 지금의 프록시로 바꿨을때 네이버 로그인이 작동되는지 확인이 안되는데 따로 확인할 방법이 있을까요? 코드상에서 유추해봐야하는건가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
환경변수를 적절히 넣은 다음 네이버 로그인을 시도해보면 되겠죠..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
간단한 줄바꿈이라면
<br />
태그를 사용하는건 어떨까요?line-height을 적절히 활용할 수 있고, 수정도 용이하다고 생각해요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 코드를 사용한다면 각 문장에 추가로 태그 처리를 해줘야 코드를 묶어서 중앙정렬을 해줄수 있어 코드의 길이가 더 늘어나지 않을까요?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text-align: center
를 사용하면 내부 태그 처리가 따로 없어도 될 거예요There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
검색 완료 시 enter키 등으로 결과를 확인하려면 구조를 어떻게 바꿔야할까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
키보드 이벤트를 추가해 결과를 입력받는 걸 추가하면 될 것 같습니다! 다음에 만들것이 위치 입력 기능인데 그때 추가하도록 하겠습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
간단하게 form + submit구조라면 네이티브 기능을 활용해 더 편하게 작성할 수 있을거예요~