refactor: 불필요한 추상화 제거

BCSDLab · Apr 5, 2024 · 69786cc · 69786cc
1 parent ea596e4
commit 69786cc
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 24 deletions.
diff --git a/src/main/java/in/koreatech/koin/domain/bus/dto/ExpressBusRemainTime.java b/src/main/java/in/koreatech/koin/domain/bus/dto/ExpressBusRemainTime.java
@@ -14,12 +14,4 @@ public ExpressBusRemainTime(LocalTime busArrivalTime, String busType) {
         super(busArrivalTime);
         this.busType = busType;
     }
-
-    public record InnerRemainTime(
-        Long busNumber,
-        Long remainTime
-    ) {
-
-    }
-
 }
diff --git a/src/main/java/in/koreatech/koin/domain/bus/util/BusOpenApiClient.java b/src/main/java/in/koreatech/koin/domain/bus/util/BusOpenApiClient.java
diff --git a/src/main/java/in/koreatech/koin/domain/bus/util/CityBusOpenApiClient.java b/src/main/java/in/koreatech/koin/domain/bus/util/CityBusOpenApiClient.java
@@ -46,7 +46,7 @@
  */
 @Component
 @Transactional(readOnly = true)
-public class CityBusOpenApiClient extends BusOpenApiClient<CityBusRemainTime> {
+public class CityBusOpenApiClient {
 
     private static final String ENCODE_TYPE = "UTF-8";
     private static final String CHEONAN_CITY_CODE = "34010";
@@ -187,7 +187,6 @@ private List<CityBusArrival> extractBusArrivalInfo(String jsonResponse) {
         }
     }
 
-    @Override
     public boolean isCacheExpired(Version version, Clock clock) {
         Duration duration = Duration.between(version.getUpdatedAt().toLocalTime(), LocalTime.now(clock));
         return duration.toSeconds() < 0 || CityBusCache.getCacheExpireSeconds() <= duration.toSeconds();

diff --git a/src/main/java/in/koreatech/koin/domain/bus/util/ExpressBusOpenApiClient.java b/src/main/java/in/koreatech/koin/domain/bus/util/ExpressBusOpenApiClient.java
@@ -29,7 +29,6 @@
 
 import in.koreatech.koin.domain.bus.dto.ExpressBusRemainTime;
 import in.koreatech.koin.domain.bus.dto.ExpressBusTimeTable;
-import in.koreatech.koin.domain.bus.model.BusRemainTime;
 import in.koreatech.koin.domain.bus.model.enums.BusOpenApiResultCode;
 import in.koreatech.koin.domain.bus.model.enums.BusStation;
 import in.koreatech.koin.domain.bus.model.express.ExpressBusArrival;
@@ -48,7 +47,7 @@
  */
 @Component
 @Transactional(readOnly = true)
-public class ExpressBusOpenApiClient extends BusOpenApiClient<BusRemainTime> {
+public class ExpressBusOpenApiClient {
 
     private static final String OPEN_API_URL = "https://apis.data.go.kr/1613000/SuburbsBusInfoService/getStrtpntAlocFndSuberbsBusInfo";
     private static final Type ARRIVAL_INFO_TYPE = new TypeToken<List<ExpressBusArrival>>() {
@@ -169,7 +168,6 @@ private List<ExpressBusRemainTime> getExpressBusRemainTime(
             .toList();
     }
 
-    @Override
     public boolean isCacheExpired(Version version, Clock clock) {
         Duration duration = Duration.between(version.getUpdatedAt().toLocalTime(), LocalTime.now(clock));
         return duration.toSeconds() < 0