Skip to content

Commit

Permalink
feat: imageUrls가 null인 경우 빈 리스트로 초기화한다. (#726)
Browse files Browse the repository at this point in the history
* feat: imageUrls가 nul인 경우 빈 배열로 초기

* feat: JsonProperty스테이크케이스로 변

---------

Co-authored-by: HyeonsuLee <leehyeonsu4888@naver.com>
  • Loading branch information
20HyeonsuLee and HyeonsuLee authored Jul 23, 2024
1 parent c4dfd9a commit fcd0935
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@

import static io.swagger.v3.oas.annotations.media.Schema.RequiredMode.REQUIRED;

import java.util.ArrayList;
import java.util.List;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.databind.PropertyNamingStrategies;
import com.fasterxml.jackson.databind.annotation.JsonNaming;

Expand Down Expand Up @@ -37,4 +40,16 @@ public record CreateReviewRequest(
@Schema(example = "[\"치킨\", \"피자\"]", description = "메뉴 이름", requiredMode = REQUIRED)
List<String> menuNames
) {
@JsonCreator
public CreateReviewRequest(
@JsonProperty("rating") @NotNull @Min(1) @Max(5) Integer rating,
@JsonProperty("content") @NotBlank String content,
@JsonProperty("image_urls") List<String> imageUrls,
@JsonProperty("menu_names") List<String> menuNames
) {
this.rating = rating;
this.content = content;
this.imageUrls = imageUrls == null? new ArrayList<>(): imageUrls;
this.menuNames = menuNames == null? new ArrayList<>(): menuNames;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@

import static io.swagger.v3.oas.annotations.media.Schema.RequiredMode.REQUIRED;

import java.util.ArrayList;
import java.util.List;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.databind.PropertyNamingStrategies;
import com.fasterxml.jackson.databind.annotation.JsonNaming;

Expand Down Expand Up @@ -37,4 +40,16 @@ public record ModifyReviewRequest(
@Schema(example = "[\"치킨\", \"피자\"]", description = "메뉴 이름", requiredMode = REQUIRED)
List<String> menuNames
) {
@JsonCreator
public ModifyReviewRequest(
@JsonProperty("rating") @NotNull @Min(1) @Max(5) Integer rating,
@JsonProperty("content") @NotBlank String content,
@JsonProperty("image_urls") List<String> imageUrls,
@JsonProperty("menu_names") List<String> menuNames
) {
this.rating = rating;
this.content = content;
this.imageUrls = imageUrls == null ? new ArrayList<>() : imageUrls;
this.menuNames = menuNames == null ? new ArrayList<>() : menuNames;
}
}

0 comments on commit fcd0935

Please sign in to comment.