-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: 회원탈퇴 Hard Delete & 슬랙 알림 발송 #352
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e79a57f
fix: Hard Delete로 수정
kwoo28 78e2cf6
feat: 회원탈퇴시 슬랙 알람 발송
kwoo28 64dc1bf
refactor: 변수명 수정
kwoo28 be57aa9
refactor: 유저 삭제시 fk 엔티티 삭제
kwoo28 097b331
refactor: 탈퇴 로직 수정
kwoo28 4e61959
refactor: 테스트 수정
kwoo28 cdf6e3e
refactor: 테스트 수정
kwoo28 a16fe5a
refactor: 로직 수정
kwoo28 2dfaee1
Merge remote-tracking branch 'origin/fix/351-delete-user' into fix/35…
kwoo28 d2358c0
refactor: 로직 수정
kwoo28 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
src/main/java/in/koreatech/koin/domain/user/model/UserDeleteEvent.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package in.koreatech.koin.domain.user.model; | ||
|
||
public record UserDeleteEvent( | ||
String email | ||
) { | ||
|
||
} |
27 changes: 27 additions & 0 deletions
27
src/main/java/in/koreatech/koin/domain/user/model/UserEventListener.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
package in.koreatech.koin.domain.user.model; | ||
|
||
import static org.springframework.transaction.event.TransactionPhase.AFTER_COMMIT; | ||
|
||
import org.springframework.stereotype.Component; | ||
import org.springframework.transaction.annotation.Propagation; | ||
import org.springframework.transaction.annotation.Transactional; | ||
import org.springframework.transaction.event.TransactionalEventListener; | ||
|
||
import in.koreatech.koin.global.domain.slack.SlackClient; | ||
import in.koreatech.koin.global.domain.slack.model.SlackNotificationFactory; | ||
import lombok.RequiredArgsConstructor; | ||
|
||
@Component | ||
@RequiredArgsConstructor | ||
@Transactional(propagation = Propagation.REQUIRES_NEW) | ||
public class UserEventListener { | ||
|
||
private final SlackClient slackClient; | ||
private final SlackNotificationFactory slackNotificationFactory; | ||
|
||
@TransactionalEventListener(phase = AFTER_COMMIT) | ||
public void onUserDeleteEvent(UserDeleteEvent event) { | ||
var notification = slackNotificationFactory.generateUserDeleteNotification(event.email()); | ||
slackClient.sendMessage(notification); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EventListener에 로직 구성해주시면 좋을거같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
withdraw에서 user삭제하고 학생과 주인은 Listener에서 삭제구현하려했는데, 이렇게 분리하니 자꾸 안돼서 Listener에서 전부 삭제구현했습니다.